Added support for async cache loading in EntityCache and EdsCacheClient #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashkolluru
commented
Oct 7, 2021
| this.edsClient = edsClient; | ||
| fqnToServiceEntityCache = | ||
| CacheBuilder.newBuilder() | ||
| .maximumSize(10000) |
Contributor
Author
There was a problem hiding this comment.
Ability to configure these caches is an existing problem. Will address them in a different PR.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
============================================
+ Coverage 80.20% 80.26% +0.05%
- Complexity 1162 1166 +4
============================================
Files 102 102
Lines 4512 4535 +23
Branches 421 421
============================================
+ Hits 3619 3640 +21
- Misses 695 696 +1
- Partials 198 199 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kotharironak
reviewed
Oct 8, 2021
| backendIdAttrsToEntityCache = | ||
| CacheBuilder.newBuilder() | ||
| .maximumSize(10000) | ||
| .expireAfterWrite(5, TimeUnit.MINUTES) |
Contributor
There was a problem hiding this comment.
Are we missing refreshAfterWrite here ?
Contributor
Author
There was a problem hiding this comment.
Yes. Fixed it.
This comment has been minimized.
This comment has been minimized.
kotharironak
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: