fix: incorrect usage of metrics hashmap for late arrival counter #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotharironak
requested review from
a team,
avinashkolluru and
laxman-traceable
avinashkolluru
approved these changes
Feb 24, 2022
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=========================================
Coverage 79.77% 79.77%
Complexity 1302 1302
=========================================
Files 118 118
Lines 5177 5178 +1
Branches 469 469
=========================================
+ Hits 4130 4131 +1
Misses 837 837
Partials 210 210
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
laxmanchekka
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my previous PR - #306, made the mistake of using the existing regular dropped counter map for registering new metrics for later arrival span. This was causing the issue of not reporting metrics.
Fixing it as part of this PR.