Skip to content

Conversation

@ravisingal
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

Merging #96 (a20288d) into main (15d3b04) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #96   +/-   ##
=========================================
  Coverage     68.63%   68.63%           
  Complexity      819      819           
=========================================
  Files            84       84           
  Lines          3475     3475           
  Branches        367      367           
=========================================
  Hits           2385     2385           
  Misses          946      946           
  Partials        144      144           
Flag Coverage Δ Complexity Δ
unit 68.63% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d3b04...a20288d. Read the comment docs.

.snyk Outdated
- '*':
reason: No replacement available
expires: 2020-12-31T00:00:00.000Z
expires: 2021-03-31T00:00:00.000Z
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we resolve the issues that are resolvable rather than extending the expiration? This one for example is fixed from grpc 1.31.0, which was released in august: https://snyk.io/vuln/SNYK-JAVA-IOGRPC-571957 - which means we've done this numerous times and aren't actually reviewing them when the expirations expire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it from the list and checked other items in the ignore list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@ravisingal ravisingal merged commit eabd6eb into main Jan 4, 2021
@ravisingal ravisingal deleted the snyk-ignore branch January 4, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants