ci: migrating to GitHub actions #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tim-mwangi
previously approved these changes
Jan 7, 2021
This comment has been minimized.
This comment has been minimized.
kotharironak
reviewed
Jan 8, 2021
| ;; | ||
| package) | ||
| CHART_VERSION=$(git describe --abbrev=0) | ||
| CHART_VERSION=$(echo ${GITHUB_REF} | cut -d/ -f 3) |
Contributor
There was a problem hiding this comment.
Here GITHUB_REF will be tag, right?
Member
Author
There was a problem hiding this comment.
GITHUB_REF will be something like GITHUB_REF=refs/tags/0.5.0 so we are extracting tag from that.
kotharironak
approved these changes
Jan 8, 2021
| HELM_GCS_CREDENTIALS: ${{ secrets.HELM_GCS_CREDENTIALS }} | ||
| HELM_GCS_REPOSITORY: ${{ secrets.HELM_GCS_REPOSITORY }} | ||
| run: | | ||
| ./.github/workflows/helm.sh package |
Contributor
There was a problem hiding this comment.
We can explore using our github-action for replacing this. But, we can do a follow-up after migration.
Unit Test Results 47 files 47 suites 45s ⏱️ Results for commit c16397b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating to GitHub actions from CircleCI as per hypertrace/hypertrace#144
unlike other repositories, this one contains helm script because of macro repo approach. Using the same script instead of custom actions.
Testing
changes are updates as per discussions and workflow here: hypertrace/query-service#47
Checklist:
Documentation