feat: support for disabling a menu item #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 751 751
Lines 15406 15409 +3
Branches 1828 1829 +1
=======================================
+ Hits 13202 13205 +3
Misses 2173 2173
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Jan 16, 2021
| .menu-item { | ||
| @include popover-menu-item; | ||
|
|
||
| &.disabled { |
Contributor
There was a problem hiding this comment.
hm, we really should make this a global style
Contributor
Author
There was a problem hiding this comment.
wanted to do that. but there are quite a few out there. some without the cursor change. So, need to audit all of them before doing a global change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for disabling a menu item.
Testing
Manually tested. UT added.
Checklist: