Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

This makes rx support a little nicer - removing the requirement to cast and automatically logging errors. Also updated GRPC version to 1.36.0

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #11 (3e943d9) into main (65a2fb0) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #11      +/-   ##
============================================
+ Coverage     68.42%   68.83%   +0.41%     
- Complexity       51       52       +1     
============================================
  Files            13       13              
  Lines           152      154       +2     
  Branches          9        9              
============================================
+ Hits            104      106       +2     
  Misses           42       42              
  Partials          6        6              
Flag Coverage Δ Complexity Δ
unit 68.83% <100.00%> (+0.41%) 0.00 <3.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rpcutils/server/rx/ServerCallStreamRxObserver.java 100.00% <100.00%> (ø) 7.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a2fb0...3e943d9. Read the comment docs.

@aaron-steinfeld aaron-steinfeld merged commit 711ea65 into main Mar 9, 2021
@aaron-steinfeld aaron-steinfeld deleted the make-rx-support-easier branch March 9, 2021 16:50
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Unit Test Results

  8 files  ±0    8 suites  ±0   7s ⏱️ -1s
38 tests ±0  38 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 711ea65. ± Comparison against base commit 65a2fb0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants