Log unresolved config instead of resolved config #74
Conversation
suresh-prakash
changed the title
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
============================================
- Coverage 70.27% 70.21% -0.06%
Complexity 106 106
============================================
Files 15 15
Lines 592 591 -1
Branches 32 32
============================================
- Hits 416 415 -1
Misses 157 157
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| private static Logger LOGGER = LoggerFactory.getLogger(ConfigUtils.class); | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigUtils.class); | ||
| private static final Set<String> SECRET_KEYS = Set.of("password", "secret"); |
There was a problem hiding this comment.
So I certainly don't want to log passwords and secrets, but I'd question why we're putting them in config files and logging them in the first place? Feel free to ping me if sensitive.
On the actual impl, rather than hardcoding these can we overload logConfFile with a method that takes keys to redact - you can route the single arg version that exists to use these two as the defaults, but that leaves consumers in control without having to modify the framework.
suresh-prakash
changed the title
No description provided.