From f303e36d9688be1c9fbaa6ec32bce1483afbbc0f Mon Sep 17 00:00:00 2001 From: Aaron Steinfeld Date: Fri, 19 Apr 2024 07:28:28 -0400 Subject: [PATCH 1/3] fix: log4j impl should not be provided by metrics --- platform-metrics/build.gradle.kts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform-metrics/build.gradle.kts b/platform-metrics/build.gradle.kts index 036ca17..dd20c7c 100644 --- a/platform-metrics/build.gradle.kts +++ b/platform-metrics/build.gradle.kts @@ -19,7 +19,6 @@ dependencies { implementation("io.github.mweirauch:micrometer-jvm-extras:0.2.2") implementation("org.slf4j:slf4j-api:1.7.36") - implementation("org.apache.logging.log4j:log4j-slf4j-impl:2.19.0") implementation("io.dropwizard.metrics:metrics-jvm:4.2.16") implementation("io.prometheus:simpleclient_dropwizard:0.12.0") implementation("io.prometheus:simpleclient_servlet:0.12.0") @@ -32,4 +31,5 @@ dependencies { testImplementation("org.junit.jupiter:junit-jupiter:5.9.0") testImplementation("org.mockito:mockito-core:4.8.0") testImplementation("com.github.ben-manes.caffeine:caffeine:3.1.8") + testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:2.19.0") } From 276f2e8413ab03e3985e135508bdff02a3bccdaa Mon Sep 17 00:00:00 2001 From: Aaron Steinfeld Date: Fri, 19 Apr 2024 08:34:28 -0400 Subject: [PATCH 2/3] chore: try updating uploader --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index c7765dc..76988f9 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -23,7 +23,7 @@ jobs: args: build jacocoTestReport - name: Upload coverage to Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v4 with: name: unit test reports fail_ci_if_error: true From 02db985b73abedfa48b4cb25906714d51131e60e Mon Sep 17 00:00:00 2001 From: Aaron Steinfeld Date: Fri, 19 Apr 2024 10:09:12 -0400 Subject: [PATCH 3/3] ci: use codecov token --- .github/workflows/build-and-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 76988f9..a8a002a 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -28,6 +28,7 @@ jobs: name: unit test reports fail_ci_if_error: true flags: unit + token: ${{ secrets.CODECOV_TOKEN }} - name: copy test reports uses: hypertrace/github-actions/gradle@main