HW-52575. Fixed ui tests #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azakrevska-epam
requested review from
fmattos-hw,
peter-joseph,
skoong and
vshcherbyna-epam
vshcherbyna-epam
approved these changes
May 15, 2019
azakrevska-epam
changed the base branch from
feature/HW-52170-key-and-field-gql-integration
to
task/HW-52170-key-and-field-gql-integration
…perwallet/hyperwallet-android-ui-sdk into task/HW-52575-ui-tests-gql-v2
skoong
requested changes
May 17, 2019
| matches(withText(R.string.add_transfer_method_fee_label))); | ||
| onView(withId(R.id.add_transfer_method_processing_label)).check( | ||
| matches(withText(R.string.add_transfer_method_processing_time_label))); | ||
| onView(withId(R.id.add_transfer_method_fee_value)).check(matches(withText("USD 2.00"))); |
Collaborator
There was a problem hiding this comment.
Leave the data the same please
Author
There was a problem hiding this comment.
@skoong returned, but I unable to to handle processing time. Where I should place it?
| matches(withText(R.string.add_transfer_method_fee_label))); | ||
| onView(withId(R.id.add_transfer_method_processing_label)).check( | ||
| matches(withText(R.string.add_transfer_method_processing_time_label))); | ||
| onView(withId(R.id.add_transfer_method_fee_value)).check(matches(withText("USD 0.25"))); |
Collaborator
There was a problem hiding this comment.
Add this back as well. Currently it's not returning on qamaster but we want to try to provide mocked reponses that will be close to the ones used.
Author
There was a problem hiding this comment.
@skoong Could you assist how to provide it via mock, please?
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/SelectTransferMethodTest.java
Show resolved
Hide resolved
Collaborator
|
Closing this PR as the fixes are in #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.