From be44e6062a1d14c579a211b81ffd0e30c2dcdeea Mon Sep 17 00:00:00 2001
From: Shanavas sabeerahamed <71114945+shanavas123@users.noreply.github.com>
Date: Wed, 10 Feb 2021 01:39:11 +0530
Subject: [PATCH 1/2] bug/DTSERWFOUR-245-Update-button-alt-text (#238)

* bug/DTSERWFOUR-245-Update-button-alt-text

* bug/DTSERWFOUR-245-Update-button-alt-text
---
 commonui/src/main/res/values/strings.xml                        | 2 ++
 receiptui/src/main/res/layout/activity_receipt_detail.xml       | 1 +
 .../src/main/res/layout/activity_add_transfer_method.xml        | 1 +
 .../src/main/res/layout/activity_list_transfer_method.xml       | 2 ++
 .../src/main/res/layout/activity_select_transfer_method.xml     | 1 +
 .../src/main/res/layout/activity_update_transfer_method.xml     | 1 +
 .../src/main/res/layout/dialog_fragment_country_selection.xml   | 1 +
 .../src/main/res/layout/dialog_fragment_currency_selection.xml  | 1 +
 transfermethodui/src/main/res/values/strings.xml                | 2 +-
 .../src/main/res/layout/activity_list_transfer_destination.xml  | 1 +
 transferui/src/main/res/layout/activity_schedule_transfer.xml   | 1 +
 .../res/layout/dialog_fragment_list_transfer_destination.xml    | 1 +
 .../main/res/layout/dialog_fragment_list_transfer_source.xml    | 1 +
 13 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/commonui/src/main/res/values/strings.xml b/commonui/src/main/res/values/strings.xml
index da5cebe47..3d67c7dc3 100644
--- a/commonui/src/main/res/values/strings.xml
+++ b/commonui/src/main/res/values/strings.xml
@@ -37,4 +37,6 @@
     <string name="edit" translatable="false">Edit</string>
     <string name="remove">Remove</string>
     <string name="remove_transfer_method_title" translatable="false">Remove this transfer method?</string>
+    <string name="navigate_back_description" translatable="false">Navigate back</string>
+    <string name="transfer_method_add_transfer_button_description" translatable="false">Add a new transfer method</string>
 </resources>
diff --git a/receiptui/src/main/res/layout/activity_receipt_detail.xml b/receiptui/src/main/res/layout/activity_receipt_detail.xml
index e3f8e4646..7a3d6fc92 100644
--- a/receiptui/src/main/res/layout/activity_receipt_detail.xml
+++ b/receiptui/src/main/res/layout/activity_receipt_detail.xml
@@ -18,6 +18,7 @@
             android:layout_height="?attr/actionBarSize"
             app:titleTextAppearance="@style/TextAppearance.Hyperwallet.Headline5"
             app:layout_collapseMode="pin"
+            app:navigationContentDescription="@string/navigate_back_description"
             app:popupTheme="@style/AppTheme.PopupOverlay"/>
 
     </com.google.android.material.appbar.AppBarLayout>
diff --git a/transfermethodui/src/main/res/layout/activity_add_transfer_method.xml b/transfermethodui/src/main/res/layout/activity_add_transfer_method.xml
index 038b0ace1..2f7b0ecfe 100644
--- a/transfermethodui/src/main/res/layout/activity_add_transfer_method.xml
+++ b/transfermethodui/src/main/res/layout/activity_add_transfer_method.xml
@@ -31,6 +31,7 @@
                     android:layout_width="match_parent"
                     android:layout_height="?attr/actionBarSize"
                     app:layout_collapseMode="pin"
+                    app:navigationContentDescription="@string/navigate_back_description"
                     app:popupTheme="@style/AppTheme.PopupOverlay" />
             </com.google.android.material.appbar.CollapsingToolbarLayout>
 
diff --git a/transfermethodui/src/main/res/layout/activity_list_transfer_method.xml b/transfermethodui/src/main/res/layout/activity_list_transfer_method.xml
index 55dd48513..146533128 100644
--- a/transfermethodui/src/main/res/layout/activity_list_transfer_method.xml
+++ b/transfermethodui/src/main/res/layout/activity_list_transfer_method.xml
@@ -25,6 +25,7 @@
                 android:layout_width="match_parent"
                 android:layout_height="?attr/actionBarSize"
                 app:layout_collapseMode="pin"
+                app:navigationContentDescription="@string/navigate_back_description"
                 app:popupTheme="@style/AppTheme.PopupOverlay">
 
                 <TextView
@@ -57,6 +58,7 @@
         android:layout_gravity="bottom|end"
         android:layout_marginEnd="@dimen/fab_right_margin"
         android:layout_marginBottom="@dimen/button_bottom_margin"
+        android:contentDescription="@string/transfer_method_add_transfer_button_description"
         app:srcCompat="@mipmap/ic_launcher_foreground"/>
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
diff --git a/transfermethodui/src/main/res/layout/activity_select_transfer_method.xml b/transfermethodui/src/main/res/layout/activity_select_transfer_method.xml
index ebf07f9cf..fafd56c6d 100644
--- a/transfermethodui/src/main/res/layout/activity_select_transfer_method.xml
+++ b/transfermethodui/src/main/res/layout/activity_select_transfer_method.xml
@@ -23,6 +23,7 @@
                 android:layout_width="match_parent"
                 android:layout_height="?attr/actionBarSize"
                 app:layout_collapseMode="pin"
+                app:navigationContentDescription="@string/navigate_back_description"
                 app:popupTheme="@style/AppTheme.PopupOverlay" >
 
                 <TextView
diff --git a/transfermethodui/src/main/res/layout/activity_update_transfer_method.xml b/transfermethodui/src/main/res/layout/activity_update_transfer_method.xml
index 35a86b7d2..6b328b08f 100644
--- a/transfermethodui/src/main/res/layout/activity_update_transfer_method.xml
+++ b/transfermethodui/src/main/res/layout/activity_update_transfer_method.xml
@@ -39,6 +39,7 @@
                     android:layout_width="match_parent"
                     android:layout_height="?attr/actionBarSize"
                     app:layout_collapseMode="pin"
+                    app:navigationContentDescription="@string/navigate_back_description"
                     app:popupTheme="@style/AppTheme.PopupOverlay" />
             </com.google.android.material.appbar.CollapsingToolbarLayout>
 
diff --git a/transfermethodui/src/main/res/layout/dialog_fragment_country_selection.xml b/transfermethodui/src/main/res/layout/dialog_fragment_country_selection.xml
index eed6c4d70..ae89217a8 100644
--- a/transfermethodui/src/main/res/layout/dialog_fragment_country_selection.xml
+++ b/transfermethodui/src/main/res/layout/dialog_fragment_country_selection.xml
@@ -14,6 +14,7 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
+        app:navigationContentDescription="@string/navigate_back_description"
         app:theme="@style/ThemeOverlay.Hyperwallet.Searchable.Selector.ActionBar" />
 
     <View
diff --git a/transfermethodui/src/main/res/layout/dialog_fragment_currency_selection.xml b/transfermethodui/src/main/res/layout/dialog_fragment_currency_selection.xml
index 499ca8004..fe87b271f 100644
--- a/transfermethodui/src/main/res/layout/dialog_fragment_currency_selection.xml
+++ b/transfermethodui/src/main/res/layout/dialog_fragment_currency_selection.xml
@@ -14,6 +14,7 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
+        app:navigationContentDescription="@string/navigate_back_description"
         app:theme="@style/ThemeOverlay.Hyperwallet.Searchable.Selector.ActionBar" />
 
     <View
diff --git a/transfermethodui/src/main/res/values/strings.xml b/transfermethodui/src/main/res/values/strings.xml
index a7af18395..406ef6ee6 100644
--- a/transfermethodui/src/main/res/values/strings.xml
+++ b/transfermethodui/src/main/res/values/strings.xml
@@ -63,7 +63,7 @@
     <string name="select_transfer_method_country_button_description">Select country button</string>
     <string name="selected_country_item_description">Selected country item</string>
     <string name="selected_currency_item_description">Selected currency item</string>
-    <string name="transfer_method_context_button_description">Context menu button</string>
+    <string name="transfer_method_context_button_description">Context menu</string>
     <string name="item_select_description">Selected item</string>
 
     <string name="error_unmapped_field">Unmapped field, Please contact support.</string>
diff --git a/transferui/src/main/res/layout/activity_list_transfer_destination.xml b/transferui/src/main/res/layout/activity_list_transfer_destination.xml
index a403e2aa4..8dab34740 100644
--- a/transferui/src/main/res/layout/activity_list_transfer_destination.xml
+++ b/transferui/src/main/res/layout/activity_list_transfer_destination.xml
@@ -22,6 +22,7 @@
         android:layout_gravity="bottom|end"
         android:layout_marginEnd="@dimen/fab_right_margin"
         android:layout_marginBottom="@dimen/button_bottom_margin"
+        android:contentDescription="@string/transfer_method_add_transfer_button_description"
         app:srcCompat="@mipmap/ic_launcher_foreground"/>
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
diff --git a/transferui/src/main/res/layout/activity_schedule_transfer.xml b/transferui/src/main/res/layout/activity_schedule_transfer.xml
index 942f07c87..1e25fb46a 100644
--- a/transferui/src/main/res/layout/activity_schedule_transfer.xml
+++ b/transferui/src/main/res/layout/activity_schedule_transfer.xml
@@ -26,6 +26,7 @@
                 android:layout_width="match_parent"
                 android:layout_height="?attr/actionBarSize"
                 app:layout_collapseMode="pin"
+                app:navigationContentDescription="@string/navigate_back_description"
                 app:popupTheme="@style/AppTheme.PopupOverlay" />
 
         </com.google.android.material.appbar.CollapsingToolbarLayout>
diff --git a/transferui/src/main/res/layout/dialog_fragment_list_transfer_destination.xml b/transferui/src/main/res/layout/dialog_fragment_list_transfer_destination.xml
index 44eca28ec..ee2ae6eb6 100644
--- a/transferui/src/main/res/layout/dialog_fragment_list_transfer_destination.xml
+++ b/transferui/src/main/res/layout/dialog_fragment_list_transfer_destination.xml
@@ -15,6 +15,7 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
+        app:navigationContentDescription="@string/navigate_back_description"
         app:theme="@style/ThemeOverlay.Hyperwallet.Selector.ActionBar" />
 
     <View
diff --git a/transferui/src/main/res/layout/dialog_fragment_list_transfer_source.xml b/transferui/src/main/res/layout/dialog_fragment_list_transfer_source.xml
index 6aa5517e1..92ba4f94d 100644
--- a/transferui/src/main/res/layout/dialog_fragment_list_transfer_source.xml
+++ b/transferui/src/main/res/layout/dialog_fragment_list_transfer_source.xml
@@ -15,6 +15,7 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
+        app:navigationContentDescription="@string/navigate_back_description"
         app:theme="@style/ThemeOverlay.Hyperwallet.Selector.ActionBar" />
 
     <View

From 357c5751f3d679c9fac3f55ea4c04b28787e0e13 Mon Sep 17 00:00:00 2001
From: Shanavas sabeerahamed <71114945+shanavas123@users.noreply.github.com>
Date: Wed, 10 Feb 2021 01:39:34 +0530
Subject: [PATCH 2/2] bug/DTSERWFOUR-243-Adjust hitbox size for tappable
 elements (#237)

---
 commonui/src/main/res/values/dimens.xml                     | 5 +++--
 transferui/src/main/res/layout/fragment_create_transfer.xml | 2 ++
 transferui/src/main/res/values/dimension.xml                | 1 +
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/commonui/src/main/res/values/dimens.xml b/commonui/src/main/res/values/dimens.xml
index f695af3a0..eeee217e5 100644
--- a/commonui/src/main/res/values/dimens.xml
+++ b/commonui/src/main/res/values/dimens.xml
@@ -77,8 +77,8 @@
     <dimen name="progress_bar_elevation">7dp</dimen>
     <dimen name="dynamic_widget_margin">22dp</dimen>
     <dimen name="icon_margin_top">1dp</dimen>
-    <dimen name="icon_default_width">24dp</dimen>
-    <dimen name="icon_default_height">24dp</dimen>
+    <dimen name="icon_default_width">32dp</dimen>
+    <dimen name="icon_default_height">32dp</dimen>
     <dimen name="menu_icon_default_margin">4dp</dimen>
     <dimen name="text_input_hint_text_padding">6dp</dimen>
     <dimen name="widget_left_margin_offset">32dp</dimen>
@@ -93,4 +93,5 @@
     <dimen name="image_offset">32dp</dimen>
     <dimen name="divider_offset">58dp</dimen>
     <dimen name="margin_top_header_value">10dp</dimen>
+    <dimen name="font_clickable_text_size">16sp</dimen>
 </resources>
diff --git a/transferui/src/main/res/layout/fragment_create_transfer.xml b/transferui/src/main/res/layout/fragment_create_transfer.xml
index abe8f8ace..144f921f5 100644
--- a/transferui/src/main/res/layout/fragment_create_transfer.xml
+++ b/transferui/src/main/res/layout/fragment_create_transfer.xml
@@ -160,7 +160,9 @@
                         android:layout_height="wrap_content"
                         android:clickable="true"
                         android:focusable="true"
+                        android:padding="@dimen/clickable_text_padding"
                         android:textAppearance="@style/TextAppearance.Hyperwallet.Clickable.Caption"
+                        android:textSize="@dimen/font_clickable_text_size"
                         android:text="@string/mobileTransferMax" />
                 </LinearLayout>
             </LinearLayout>
diff --git a/transferui/src/main/res/values/dimension.xml b/transferui/src/main/res/values/dimension.xml
index 8940e7016..5d8d71926 100644
--- a/transferui/src/main/res/values/dimension.xml
+++ b/transferui/src/main/res/values/dimension.xml
@@ -15,4 +15,5 @@
     <dimen name="currency_code_padding_2">18dp</dimen>
     <dimen name="currency_code_padding_3">25dp</dimen>
     <dimen name="amount_container_height">80dp</dimen>
+    <dimen name="clickable_text_padding">10dp</dimen>
 </resources>
\ No newline at end of file