HW-52585 UI - Receipt Details #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receipt/src/main/java/com/hyperwallet/android/receipt/view/ReceiptDetailFragment.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/receipt/view/ReceiptDetailFragment.java
Outdated
Show resolved
Hide resolved
…e/HW-52585-ui-receipt-details # Conflicts: # receipt/src/main/AndroidManifest.xml # receipt/src/main/res/layout/item_receipt.xml
|
I think in new classes there are lot of code what could be refactored to smaller methods. |
added 5 commits
June 14, 2019 07:53
…e/HW-52585-ui-receipt-details # Conflicts: # receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ListReceiptActivity.java # receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ListReceiptFragment.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/ListTransferMethodActivity.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/ListTransferMethodFragment.java # ui/src/main/java/com/hyperwallet/android/ui/transfermethod/SelectTransferMethodFragment.java
fmattos-hw
requested changes
Jun 15, 2019
Collaborator
fmattos-hw
left a comment
fmattos-hw
left a comment
There was a problem hiding this comment.
PR looks good in general. I like the idea of reusability introduced by ReceiptViewUtil(which I'm going to spend some time thinking about to make sure we're going to apply a similar idea to other cases in the future - but I might request some changes) and usage of merge/include.
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptDetailActivity.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptDetailFragment.java
Outdated
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptDetailFragment.java
Show resolved
Hide resolved
added 6 commits
June 17, 2019 08:48
fmattos-hw
requested changes
Jun 18, 2019
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptViewUtil.java
Outdated
Show resolved
Hide resolved
fmattos-hw
requested changes
Jun 18, 2019
Collaborator
fmattos-hw
left a comment
fmattos-hw
left a comment
There was a problem hiding this comment.
Code looks good in general, just a few little things, well done!
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptDetailFragment.java
Show resolved
Hide resolved
receipt/src/main/java/com/hyperwallet/android/ui/receipt/view/ReceiptDetailActivity.java
Show resolved
Hide resolved
fmattos-hw
approved these changes
Jun 19, 2019
skoong
approved these changes
Jun 19, 2019
vshcherbyna-epam
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.