HW-52538 add support to deactivate paypal account #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-joseph
requested changes
May 9, 2019
Collaborator
peter-joseph
left a comment
peter-joseph
left a comment
There was a problem hiding this comment.
Generally looks good, just minor adjustment in mapping
| <string name="wire_account">Wire Account</string> | ||
| <string name="paper_check">Paper Check</string> | ||
| <string name="prepaid_card">Prepaid Card</string> | ||
| <string name="paypal_account">PayPal</string> |
Collaborator
There was a problem hiding this comment.
should this be PayPal Account ?
Collaborator
Author
There was a problem hiding this comment.
According to @jsaini-hw it should be PayPal
ui/src/main/res/values/strings.xml
Outdated
| <string name="bank_card_font_icon">\uE005</string> | ||
| <string name="wire_account_font_icon">\uE00D</string> | ||
| <string name="paper_check_font_icon">\uE002</string> | ||
| <string name="prepaid_card_font_icon">\uE00E</string> |
Collaborator
There was a problem hiding this comment.
I think Prepaid card is remapped to E00A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the changes to allow users to deactivate a PayPal account. It also includes updates to the string.xml file to map the PayPal icon and description