Feature/hw 66544 v4 user upload multipart #60
Conversation
…66544-V4-UserUploadMultipart # Conflicts: # src/test/java/com/hyperwallet/clientsdk/HyperwalletTest.java
| public WebResource getWebResource(final String url) { | ||
| client.addFilter(new HTTPBasicAuthFilter(this.username, this.password)); | ||
| webResource = client.resource(url); | ||
| return webResource; |
There was a problem hiding this comment.
Can be changed to: return client.resource(url);
There was a problem hiding this comment.
Changed as suggested.
| hyperwalletUserresponse.getDocuments().get(0).getCountry().equals(ECountryCode.CA); | ||
| hyperwalletUserresponse.getDocuments().get(0).getStatus().equals(EKycDocumentVerificationStatus.NEW); | ||
| } catch (HyperwalletException e) { | ||
| } |
There was a problem hiding this comment.
Catch block removed and added assert statements
|
|
||
| hyperwalletApiClient.put(baseUrl + "/documentUpload", multiPart, HyperwalletUser.class); | ||
| } catch (Exception exception) { | ||
| } |
There was a problem hiding this comment.
Catch block removed and added assert statements.
| @JsonFilter(HyperwalletJsonConfiguration.INCLUSION_FILTER) | ||
| @XmlRootElement | ||
| @XmlAccessorType(XmlAccessType.FIELD) | ||
| public class DocumentVerificationDocumentsRepresentation { |
There was a problem hiding this comment.
Class name can be changed to HyperwalletDocument with more details about the class in the javadoc
There was a problem hiding this comment.
Changed class name.
There was a problem hiding this comment.
Sorry please have a look, main takeaway is importing the whole jersey client and is used only in 1 use case which is PUT with multipart MIME, We don't want integrator to have that library in their build too, the goal is to make our SDK as lightweight as possible
| <dependency> | ||
| <groupId>com.sun.jersey</groupId> | ||
| <artifactId>jersey-client</artifactId> | ||
| <version>1.18</version> |
There was a problem hiding this comment.
is this library used only for multipart mime? can we have our implementation that does that part only?
the reason being is we are adding library that is only used in 1 use case, and it will make the SDK heavy for the integrators cause the will be added on top of their current library deps
| Response response = new Response(); | ||
| try { | ||
| webResource = getWebResource(url); | ||
| ClientResponse clientResponse = webResource.type(MediaType.MULTIPART_FORM_DATA_TYPE).put(ClientResponse.class, formDataMultiPart); |
There was a problem hiding this comment.
I think we can have our own small implementation of pushing multipart http thru normal io streams, can we do that instead? rather than importing the whole jersey client?
There was a problem hiding this comment.
hw2 app is consuming the documents with FormDataMultiPart
public Response uploadDocuments(@UserToken @PathParam("userToken") String userToken, final FormDataMultiPart multiPart,
@Context UriInfo uriInfo)
throws Exception {
That is the reason why we went with this approach. Please let me know if still we need to change it.
No description provided.