From 7219193242a3c6442ff53c10555071f53e4e7a58 Mon Sep 17 00:00:00 2001
From: David M <maniac@case-of.org>
Date: Thu, 21 Sep 2023 12:50:31 +0200
Subject: [PATCH] Issue #234: Use daemon threads for sending thread pool

---
 README.md                                     |  1 +
 .../dbus/connections/AbstractConnection.java  | 19 +++++--------------
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index 72d12d79..f37db976 100644
--- a/README.md
+++ b/README.md
@@ -87,6 +87,7 @@ The library will remain open source and MIT licensed and can still be used, fork
    - Improved logging and handling of disconnected transports in `DBusDaemon`, thanks to [brett-smith](https://github.com/brett-smith) ([#225](https://github.com/hypfvieh/dbus-java/issues/225))
    - Added additional transport (dbus-java-junixsocket), thanks to [Prototik](https://github.com/Prototik) ([#227](https://github.com/hypfvieh/dbus-java/issues/227)) for providing the implementation
    - Smaller refactorings to avoid code duplication for new transport
+   - Use daemon threads in `ExecutorService` for DBus-Sender-Threads ([#234](https://github.com/hypfvieh/dbus-java/issues/234))
 
 ##### Changes in 4.3.0 (2023-03-10):
 
diff --git a/dbus-java-core/src/main/java/org/freedesktop/dbus/connections/AbstractConnection.java b/dbus-java-core/src/main/java/org/freedesktop/dbus/connections/AbstractConnection.java
index be109bab..127fda4f 100644
--- a/dbus-java-core/src/main/java/org/freedesktop/dbus/connections/AbstractConnection.java
+++ b/dbus-java-core/src/main/java/org/freedesktop/dbus/connections/AbstractConnection.java
@@ -9,25 +9,16 @@
 import org.freedesktop.dbus.errors.Error;
 import org.freedesktop.dbus.errors.UnknownMethod;
 import org.freedesktop.dbus.errors.UnknownObject;
-import org.freedesktop.dbus.exceptions.DBusException;
-import org.freedesktop.dbus.exceptions.DBusExecutionException;
-import org.freedesktop.dbus.exceptions.FatalDBusException;
-import org.freedesktop.dbus.exceptions.NotConnected;
-import org.freedesktop.dbus.interfaces.CallbackHandler;
-import org.freedesktop.dbus.interfaces.DBusInterface;
-import org.freedesktop.dbus.interfaces.DBusSigHandler;
+import org.freedesktop.dbus.exceptions.*;
+import org.freedesktop.dbus.interfaces.*;
 import org.freedesktop.dbus.messages.*;
 import org.freedesktop.dbus.utils.LoggingHelper;
 import org.freedesktop.dbus.utils.NameableThreadFactory;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.Closeable;
-import java.io.EOFException;
-import java.io.IOException;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
-import java.lang.reflect.Type;
+import java.io.*;
+import java.lang.reflect.*;
 import java.nio.channels.ClosedByInterruptException;
 import java.util.*;
 import java.util.Map.Entry;
@@ -114,7 +105,7 @@ protected AbstractConnection(TransportConfig _transportConfig, ReceivingServiceC
 
         receivingService = new ReceivingService(_rsCfg);
         senderService =
-                Executors.newFixedThreadPool(1, new NameableThreadFactory("DBus Sender Thread-", false));
+            Executors.newFixedThreadPool(1, new NameableThreadFactory("DBus Sender Thread-", true));
 
         objectTree = new ObjectTree();
         fallbackContainer = new FallbackContainer();