Order alerts by type and sent time (+polish) #418
Conversation
Remove composed and received time since they aren’t useful to users.
| if(isN2NTM0 && isN2NTM1) { // newest first | ||
| if(a0.getUpdatedTime() < a1.getUpdatedTime()) return 1; | ||
| else if(a0.getUpdatedTime() > a1.getUpdatedTime()) return -1; | ||
| } |
There was a problem hiding this comment.
Ordering by updated time is always more sensible than ordering by hash code. I don't see the need to restrict this to N2NTMUserAlert. Apart from that, I'd prefer the UserAlertManager to be as agnostic as possible of the kind of UserAlert.
There was a problem hiding this comment.
so I should just leave out the (isN2NTMx)?
|
Are you aware of the possibilities |
This fits the goal of showing the newest message first, and if a friend was offline for some time, the sent time would not fit that. Thanks to bertm.
|
I’m using Mercurial to interface with github, there the equivalent command is called histedit, but I wasn’t in my source tree when I filed the pull request — and as you saw it took me 3 days to get into it again, so I decided to say sorry instead of delaying the pull request But still, thank you for the short guide. I might need it one day. The comment messages are fixed now. |
|
No problem Looks good to me. |
|
Thank you for reviewing! |
ArneBab
changed the title
| @@ -1039,7 +1039,7 @@ N2NTMToadlet.tooLarge=The file you have uploaded through your browser is ${attem | |||
| N2NTMToadlet.sizeWarning=Please note that browser-based uploading has a limit of ${limit}. | |||
| N2NTMToadlet.uploadFailed=Failed to upload file. | |||
| N2NTMUserAlert.delete=Delete | |||
| N2NTMUserAlert.header=From: ${from} (composed ${composed} | sent ${sent} | received ${received}) | |||
| N2NTMUserAlert.header=From: ${from} (sent ${sent}) | |||
There was a problem hiding this comment.
Composed might not be especially useful information, but I think both sent and received are. I know when I want to know about the timing of texts when I come out of a basement without cell coverage or something I'll want to know when it was sent, but if I come back to my phone to something like "ready to go in an hour" I'll want to know when it was received to know if I ever had a chance of responding in time. Thoughts?
I'm tired so this is too rambly but hopefully it makes sense anyway.
There was a problem hiding this comment.
My apologies for not catching this earlier, but sentTime can apparently be deceiving: it is set as the time at which the N2N message is dispatched to the Node's MessageCore (source) where it is queued for transmission over the network, if and only if the peer is currently connected. It should be really close to receivedTime if we ignore clock skew problems.
composedTime might be the one you are after knowing.
|
This should fix both (and the comment is now actually useful, stating that it orders newest first). I cut out the “sent” from the alert, because I think that it’s not actually a relevant information for users, so it just adds to the line noise. |
|
thank you! |
(just what the title says)