Debian package continuation #774

ArneBab · 2022-05-19T17:36:29Z

No description provided.

desyncr · 2022-05-21T20:08:19Z

…ian-pkg

ArneBab · 2022-06-05T22:52:44Z

@desyncr what’s the state of the debian package? Are the todo points up to date?

desyncr · 2022-06-08T16:22:26Z

@ArneBab Hey there Arne, yes the TODO points are up to date and I'll keep them up do date with each iteration. I'll continue working tackling down the low hanging fruits (missing attribution, instructions) then test and iterate over multiple OSes.
Hopefully getting to a point of testing soon (few weeks).

ArneBab · 2022-06-08T16:29:22Z

@desyncr thank you! ❤️

desyncr · 2022-06-18T18:19:46Z

Lintian warnings and errors pending:

Now running lintian freenet_0.7.5+1493-1_amd64.changes ...
E: freenet changes: bad-distribution-in-changes-file unstable
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet force-reload
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet restart
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet start
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet stop
E: freenet: init.d-script-missing-dependency-on-local_fs etc/init.d/freenet: required-stop
E: freenet: init.d-script-should-always-start-service etc/default/freenet (line 10)
E: freenet source: temporary-debhelper-file freenet.debhelper.log
W: freenet source: custom-compression-in-debian-rules dh_builddeb -- -Zgzip (line 46)
W: freenet: init.d-script-does-not-source-init-functions etc/init.d/freenet
W: freenet: initial-upload-closes-no-bugs
W: freenet: missing-systemd-service-for-init.d-script freenet
W: freenet source: package-needs-versioned-debhelper-build-depends 11
W: freenet: unknown-field freenet_0.7.5+1493-1_amd64.deb Tag
N: 26 hints overridden (26 errors)
Finished running lintian.

ArneBab · 2022-06-18T23:38:13Z

Nice progress!

desyncr · 2022-06-25T21:30:24Z

Packaging guide: https://github.com/freenet/wiki/wiki/Debian-package

ArneBab · 2022-07-16T17:50:46Z

@desyncr does this mean, you finished the packaging now?

desyncr · 2022-07-16T18:01:51Z

They're some errors and warnings still. But the package builds and works.

I'd say the package is ready to go since the errors are related to how the init script works with the wrapper.
Besides that since we don't intent to be in the debian's repositories I'd not care too much about these errors.

I'd like to have some feedback from users installing the"beta" versions.

ArneBab · 2022-09-15T22:48:08Z

@desyncr did you already get enough feedback or should I try it in a VM?

desyncr · 2022-09-15T23:05:26Z

@ArneBab I did have some feedback regarding packagecloud.io not having the packages for different versions, which is true. I need to build a package and upload to the different debian and ubuntu versions.

My concern with packagecloud.io is that the disk quota will be exhausted very quickly if I have to upload the same package for each version we want to support. Alternatives are very little as far as I'm concern:

Hosting it under the Freenet Project Inc umbrella will introduce monthly costs which I'd not like to incur.
Submitting to Debian will definitely take a long while since I'm not able to progress much on the linting issues, let alone any feedback the Debian packaging team might have.

Regardless of the linting issues, the package does build and runs correctly. I'm using it on my node without problems (although my node doesn't have a high uptime).

ArneBab · 2022-09-16T05:14:32Z

Can you share the current lint output? Maybe I can help get that fixed.

desyncr · 2022-09-17T11:10:46Z

@ArneBab Here they are, not much progress :(

Now running lintian freenet_0.7.5+1494-4_amd64.changes ...
E: freenet changes: bad-distribution-in-changes-file unstable
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet force-reload
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet restart
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet start
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet stop
E: freenet: init.d-script-missing-dependency-on-local_fs etc/init.d/freenet: required-stop
E: freenet: init.d-script-should-always-start-service etc/default/freenet (line 10)
W: freenet source: custom-compression-in-debian-rules dh_builddeb -- -Zgzip (line 42)
W: freenet: init.d-script-does-not-source-init-functions [etc/init.d/freenet]
W: freenet: missing-systemd-service-for-init.d-script freenet [etc/init.d/freenet]
W: freenet source: no-debian-changes
W: freenet source: no-versioned-debhelper-prerequisite 11
W: freenet: unknown-field Tag
N: 6 hints overridden (6 errors); 0 unused override

desyncr · 2022-09-17T14:59:19Z

Updated errors with some overrides:

E: freenet changes: bad-distribution-in-changes-file unstable
E: freenet: init.d-script-missing-dependency-on-local_fs etc/init.d/freenet: required-stop
E: freenet: init.d-script-should-always-start-service etc/default/freenet (line 10)
W: freenet source: debian-rules-should-not-use-custom-compression-settings dh_builddeb -- -Zgzip (line 42)
W: freenet: init.d-script-does-not-source-init-functions etc/init.d/freenet
W: freenet source: latest-debian-changelog-entry-reuses-existing-version 0.7.5+1494-7 ~= 0.7.5+1494-7 (last used: Sat, 17 Sep 2022 13:57:51 +0100)
W: freenet: missing-systemd-service-for-init.d-script freenet
W: freenet source: newer-standards-version 4.5.1 (current is 4.5.0)
W: freenet source: package-needs-versioned-debhelper-build-depends 11
N: 30 tags overridden (30 errors)
Finished running lintian.

Some notes on the error messages:

E: freenet changes: bad-distribution-in-changes-file unstable

You’ve specified an unknown target distribution for your upload in the debian/changelog file. It is possible that you are uploading for a different distribution than the one Lintian is checking for. In that case, passing –profile $VENDOR may fix this warning.
(source)

In a .changes file or parsed changelog output this contains the (space-separated) name(s) of the distribution(s) where this version of the package should be installed. Valid distributions are determined by the archive maintainers. 10 The Debian archive software only supports listing a single distribution. Migration of packages to other distributions is handled outside of the upload process.
(source)

See here for explanation on this behaviour.

E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet force-reload

The /etc/init.d scripts have to support the following command line arguments: start, stop, restart, force-reload.
(source)

Checkout freenet/debian example:

# lintian not smart enough to detect these things for service-wrapper-java
freenet-daemon binary: init.d-script-does-not-source-init-functions etc/init.d/freenet-daemon
freenet-daemon binary: init.d-script-does-not-implement-required-option etc/init.d/freenet-daemon start
freenet-daemon binary: init.d-script-does-not-implement-required-option etc/init.d/freenet-daemon stop
freenet-daemon binary: init.d-script-does-not-implement-required-option etc/init.d/freenet-daemon restart
freenet-daemon binary: init.d-script-does-not-implement-required-option etc/init.d/freenet-daemon force-reload
freenet-daemon binary: init.d-script-does-not-implement-optional-option etc/init.d/freenet-daemon status

E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet force-reload
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet restart
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet start
E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet stop

From man:

For binary packages, Lintian looks for overrides in a file named
usr/share/lintian/overrides/<package> inside the binary package, where
<package> is the name of the binary package.  For source packages,
Lintian looks for overrides in debian/source/lintian-overrides and then
in debian/source.lintian-overrides if the first file is not found.  The
first path is preferred.  See the Lintian User's Manual for the syntax
of overrides.

desyncr · 2022-09-17T15:17:57Z

@ArneBab By the way, the build process can be seen here.

ArneBab · 2022-09-17T21:22:32Z

The Zgzip error sounds like it could be caused by this line:

override_dh_builddeb:
	dh_builddeb -- -Zgzip

ArneBab · 2022-11-05T18:21:42Z

@desyncr will you take care of the Zgzip error? What’s still missing to get this done?

Thynix · 2022-11-09T10:39:39Z

build.gradle

@@ -94,7 +94,7 @@ task jar (type: Jar, overwrite: true) {
        exclude 'freenet/node/Version.class'
        exclude 'freenet/node/Version$1.class'
    }
-    preserveFileTimestamps = false
+    preserveFileTimestamps = true


What's the reasoning for setting this to true? For deterministic builds it needs to be false - documentation of that is here. If there's a need that it not be deterministic, I think we'd need another task to build for the Debian package.

ArneBab · 2023-03-29T07:09:17Z

@desyncr are you still working on this?

ArneBab · 2023-07-25T08:03:42Z

I looked into this again and I see no dangerous stuff, so I decided to merge it. I’ll undo the preserveFileTimestamps change on next.

desyncr force-pushed the debian-pkg branch 2 times, most recently from da57938 to 85cb5c3 Compare May 21, 2022 20:04

Debian package continuation

ba4660e

desyncr force-pushed the debian-pkg branch from 85cb5c3 to ba4660e Compare May 21, 2022 20:06

desyncr added 5 commits May 21, 2022 21:08

Delete freenet.ini

6569f13

Add functions to retrieve seednodes

212eeaf

Remove seednodes.fref

ec7e8d7

Merge branch 'debian-pkg' of github.com-desyncr:desyncr/fred into deb…

7e03d25

…ian-pkg

Update clean target

989cdfb

Lintian warning and error fix ups

61e41a4

desyncr added 3 commits June 25, 2022 02:42

Add missing dependencies for debian bookworm

5fd59ab

Add github action

8ca925f

Build binary package only, add build dependencies

61cf825

desyncr force-pushed the debian-pkg branch from a7d8835 to 61cf825 Compare June 25, 2022 03:27

desyncr added 10 commits June 25, 2022 05:23

Use gbp build package

20631e6

apt update

8c24ac8

Custom action and install deps

acdfbb5

Install build script dependencies

7667ec8

Missing sudo for apt-get on GH actions

a444886

Missing equivs dependency

e802445

Missing privileges in GH actions

379a4b6

Remove freenet deps .deb package

46fb0cc

Merge branch 'freenet:next' into debian-pkg

c648b1f

Cache steps and gradle configuration

e967e67

Remove gradle.properties generation

a6c426d

desyncr force-pushed the debian-pkg branch from 154c92d to 1b6f76e Compare June 25, 2022 18:35

Streamline clean up task

4e037e3

desyncr force-pushed the debian-pkg branch from 1b6f76e to 4e037e3 Compare June 25, 2022 18:46

desyncr added 7 commits July 2, 2022 00:10

Update changelog

75a1b51

Update maintainer name

ad98241

Update maintainer name

75b9d50

Add attribution to original work

4b79a0d

Update package build descriptions

3cf607b

Update github action to test package generation only on tags and master

5b99c29

Remove unnecessary file entries

e281533

desyncr added 3 commits September 17, 2022 14:02

Lintian overrides

516a87d

Build on debian-pkg branch

5c4a051

Update changelog

a2f314b

Thynix requested changes Nov 9, 2022

View reviewed changes

ArneBab merged commit ed7d74c into hyphanet:next Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Debian package continuation #774

Debian package continuation #774

ArneBab commented May 19, 2022

desyncr commented May 21, 2022 •

edited

Loading

ArneBab commented Jun 5, 2022 •

edited

Loading

desyncr commented Jun 8, 2022

ArneBab commented Jun 8, 2022

desyncr commented Jun 18, 2022

ArneBab commented Jun 18, 2022

desyncr commented Jun 25, 2022 •

edited

Loading

ArneBab commented Jul 16, 2022 •

edited

Loading

desyncr commented Jul 16, 2022

ArneBab commented Sep 15, 2022

desyncr commented Sep 15, 2022 •

edited

Loading

ArneBab commented Sep 16, 2022

desyncr commented Sep 17, 2022

desyncr commented Sep 17, 2022

desyncr commented Sep 17, 2022

ArneBab commented Sep 17, 2022

ArneBab commented Nov 5, 2022

Thynix Nov 9, 2022

ArneBab commented Mar 29, 2023

ArneBab commented Jul 25, 2023

Debian package continuation #774

Debian package continuation #774

Conversation

ArneBab commented May 19, 2022

desyncr commented May 21, 2022 • edited Loading

ArneBab commented Jun 5, 2022 • edited Loading

desyncr commented Jun 8, 2022

ArneBab commented Jun 8, 2022

desyncr commented Jun 18, 2022

ArneBab commented Jun 18, 2022

desyncr commented Jun 25, 2022 • edited Loading

ArneBab commented Jul 16, 2022 • edited Loading

desyncr commented Jul 16, 2022

ArneBab commented Sep 15, 2022

desyncr commented Sep 15, 2022 • edited Loading

ArneBab commented Sep 16, 2022

desyncr commented Sep 17, 2022

desyncr commented Sep 17, 2022

E: freenet changes: bad-distribution-in-changes-file unstable

E: freenet: init.d-script-does-not-implement-required-option etc/init.d/freenet force-reload

desyncr commented Sep 17, 2022

ArneBab commented Sep 17, 2022

ArneBab commented Nov 5, 2022

Thynix Nov 9, 2022

Choose a reason for hiding this comment

ArneBab commented Mar 29, 2023

ArneBab commented Jul 25, 2023

desyncr commented May 21, 2022 •

edited

Loading

ArneBab commented Jun 5, 2022 •

edited

Loading

desyncr commented Jun 25, 2022 •

edited

Loading

ArneBab commented Jul 16, 2022 •

edited

Loading

desyncr commented Sep 15, 2022 •

edited

Loading