Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upIncorrect timestamp formatting in Chrome v58 #378
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
May 9, 2017
Contributor
Test case derived from the logic in src/sidebar/time.js:
new Date('2016-11-01').toLocaleString(undefined, { day: 'numeric', month: 'short', year: 'numeric' })
// Chrome v58: "2016 M11 1"
// Safari, Firefox: 1 Nov 2016The locale argument is optional, in which according to MDN the runtime's default locale is used. If "en" is passed as the locale argument then the output matches what is expected: "Nov 1, 2016".
|
Test case derived from the logic in new Date('2016-11-01').toLocaleString(undefined, { day: 'numeric', month: 'short', year: 'numeric' })
// Chrome v58: "2016 M11 1"
// Safari, Firefox: 1 Nov 2016The |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
May 9, 2017
Contributor
This issue appears to occur only when the system language is set to English. If I change the system language to French on my OS X system and restart Chrome, the same expression evaluates to "1 nov. 2016".
|
This issue appears to occur only when the system language is set to English. If I change the system language to French on my OS X system and restart Chrome, the same expression evaluates to "1 nov. 2016". |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
May 9, 2017
Contributor
Reported upstream at https://bugs.chromium.org/p/chromium/issues/detail?id=720030
|
Reported upstream at https://bugs.chromium.org/p/chromium/issues/detail?id=720030 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
May 24, 2017
Contributor
The upstream investigation is ongoing. In the meantime I note that I am unable to reproduce the problem in the dev version of Chrome (M60) locally.
|
The upstream investigation is ongoing. In the meantime I note that I am unable to reproduce the problem in the dev version of Chrome (M60) locally. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
May 30, 2017
Contributor
This has been fixed upstream for Chrome 59 but it looks like the fix is not going to be backported to Chrome 58. We might want to put a workaround in place for a couple of months or so.
|
This has been fixed upstream for Chrome 59 but it looks like the fix is not going to be backported to Chrome 58. We might want to put a workaround in place for a couple of months or so. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
robertknight
Sep 26, 2017
Contributor
Chrome stable is now v61, so there isn't that much point in fixing this.
|
Chrome stable is now v61, so there isn't that much point in fixing this. |
robertknight commentedMay 6, 2017
Steps to reproduce
Expected behaviour
The timestamp should be formatted as "30 Nov 2016"
Actual behaviour
Browser/system information
Chrome 58.0.3029.96 on OS X. Works as expected in Safari 10.1 and Firefox.