Page note tab not focused when only page notes are present.

[dwhly]

Steps to reproduce

1. Find a page with only a page note and no annotations
2. Pull out the sidebar

Expected behaviour

Page note tab should be selected

Actual behaviour

Empty annotation tab is selected.

Browser/system information

Any

Additional details

This was an implementation detail that was identified back in the design process, but may never have been recorded. Most definitely we shouldn't show an empty tab when there are legitimate annotations (as page notes) present (though I would argue not orphans). @conordelahunty Can I get an assist?

[ghost]

Hey, yes this was discussed but I think it then got mixed up when we had a discussion on preserving the users selection (if I am viewing a page and am on the page note tab, then I should be on that tab when I go to another document) but as you say, I'm not sure that this was recorded so am not sure what logic (if any) we have in there right now? Perhaps @sheetaluk might be able to explain how this works currently?

[ghost]

Hey, yes this was discussed but I think it then got mixed up when we had a discussion on preserving the users selection (if I am viewing a page and am on the page note tab, then I should be on that tab when I go to another document) but as you say, I'm not sure that this was recorded so am not sure what logic (if any) we have in there right now? Perhaps @sheetaluk might be able to explain how this works currently?

[dwhly]

if I am viewing a page and am on the page note tab, then I should be on that tab when I go to another document.

Worth discussing whether there's a natural rationale for stickiness with the tab bar. But in any event, we may not want to show an empty page note or annotation tab when there are annotations present in the other, regardless of the tab I was looking at in the last page that I was on. (Probably an obvious statement.)

[dwhly]

if I am viewing a page and am on the page note tab, then I should be on that tab when I go to another document.

Worth discussing whether there's a natural rationale for stickiness with the tab bar. But in any event, we may not want to show an empty page note or annotation tab when there are annotations present in the other, regardless of the tab I was looking at in the last page that I was on. (Probably an obvious statement.)

[sheetaluk]

Hi!
So here is how it works currently:

On page load and on group change, select the annotations tab by default,
for consistency. This is because with the orphans tab, it can get confusing
that sometimes the orphans tab shows up and sometimes it doesnt. Also, when
the orphans tab is selected, switching to a group which doesn't have
orphans would confuse the user if sometimes the annotations tab was
selected and other times the notes tab.

I do agree that we shouldn't show an empty annotations tab when there are
page notes available. I wonder if we could show the empty annotations tab,
but explicitly say something like "There are no annotations, but click here
to view all 'n' page notes." or something along those lines, in addition to
the page notes tab and the count right next to it.

Also, I think it would be good to list desired behaviour for various cases:

1. On page load default to annotations tab if there are annotations,
   otherwise page notes if there are page notes.
2. If there are no annotations or page notes, default to the annotations
   tab.
3. If a user has made a tab selection of annotation or notes and changes a
   group, carry over the tab selection on group change.
4. If a user has selected the annotations tab and switches to a group which
   has no annotations but has page notes <what do we do?>
5. Similarly, if a user has selected the page notes tab and switches to a
   group which has no notes but only annotations, <what do we do?>
6. If a user has selected the orphans tab and changes group or reloads the
   page, <what do we do?>
7. If a user lands on a direct link which is an orphaned annotation, on
   clearing the selection, what tab should they default to?

Just a few cases off the top of my head. If we had any other scenarios we
should consider them as well.

On Wed, Jul 27, 2016 at 9:15 AM, Conor Delahunty notifications@github.com
wrote:

Hey, yes this was discussed but I think it then got mixed up when we had a
discussion on preserving the users selection (if I am viewing a page and am
on the page note tab, then I should be on that tab when I go to another
document) but as you say, I'm not sure that this was recorded so am not
sure what logic (if any) we have in there right now? Perhaps @sheetaluk
https://github.com/sheetaluk might be able to explain how this works
currently?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAepqgfHiN8wmNYWafPwp7dv1fl2ZLxsks5qZ1oLgaJpZM4JVhoh
.

-- Sheetal, the Invincible
-- twitter.com/sheetaluk

[sheetaluk]

Hi!
So here is how it works currently:

On page load and on group change, select the annotations tab by default,
for consistency. This is because with the orphans tab, it can get confusing
that sometimes the orphans tab shows up and sometimes it doesnt. Also, when
the orphans tab is selected, switching to a group which doesn't have
orphans would confuse the user if sometimes the annotations tab was
selected and other times the notes tab.

I do agree that we shouldn't show an empty annotations tab when there are
page notes available. I wonder if we could show the empty annotations tab,
but explicitly say something like "There are no annotations, but click here
to view all 'n' page notes." or something along those lines, in addition to
the page notes tab and the count right next to it.

Also, I think it would be good to list desired behaviour for various cases:

1. On page load default to annotations tab if there are annotations,
   otherwise page notes if there are page notes.
2. If there are no annotations or page notes, default to the annotations
   tab.
3. If a user has made a tab selection of annotation or notes and changes a
   group, carry over the tab selection on group change.
4. If a user has selected the annotations tab and switches to a group which
   has no annotations but has page notes <what do we do?>
5. Similarly, if a user has selected the page notes tab and switches to a
   group which has no notes but only annotations, <what do we do?>
6. If a user has selected the orphans tab and changes group or reloads the
   page, <what do we do?>
7. If a user lands on a direct link which is an orphaned annotation, on
   clearing the selection, what tab should they default to?

Just a few cases off the top of my head. If we had any other scenarios we
should consider them as well.

On Wed, Jul 27, 2016 at 9:15 AM, Conor Delahunty notifications@github.com
wrote:

Hey, yes this was discussed but I think it then got mixed up when we had a
discussion on preserving the users selection (if I am viewing a page and am
on the page note tab, then I should be on that tab when I go to another
document) but as you say, I'm not sure that this was recorded so am not
sure what logic (if any) we have in there right now? Perhaps @sheetaluk
https://github.com/sheetaluk might be able to explain how this works
currently?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAepqgfHiN8wmNYWafPwp7dv1fl2ZLxsks5qZ1oLgaJpZM4JVhoh
.

-- Sheetal, the Invincible
-- twitter.com/sheetaluk

[dwhly]

@sheetaluk (per our slack chat yesterday):

I wonder if we could show the empty annotations tab, but explicitly say something like "There are no annotations, but click here to view all 'n' page notes." or something along those lines, in addition to the page notes tab and the count right next to it.

Let's just go ahead and show the page notes tab. If anything you could alert in reverse "There were no annotations, only the page notes above". But perhaps that should be based on user feedback?

On page load default to annotations tab if there are annotations, otherwise page notes if there are page notes.

Yes.

If there are no annotations or page notes, default to the annotations tab.

Yes.

If a user has made a tab selection of annotation or notes and changes a group, carry over the tab selection on group change.

I'm not so sure about this one-- I think we should just stick w/ the default behavior you've scoped out above vs having the sticky tab selection. Since it's extra code & complexity-- lets wait until we get clear feedback to the contrary. Not apparent to me that stickiness here would be the intuitive thing.

If a user has selected the annotations tab and switches to a group which has no annotations but has page notes <what do we do?>

Same as above. Default behavior is that if there are no annotations but there are page notes, then show the page notes.

Similarly, if a user has selected the page notes tab and switches to a group which has no notes but only annotations, <what do we do?>

Annotations tab. Per above.

If a user has selected the orphans tab and changes group or reloads the page, <what do we do?>

Per above. Use the default behavior.

If a user lands on a direct link which is an orphaned annotation, on clearing the selection, what tab should they default to?

Interesting question. The simplest thing would be to show all orphans, which presumably is the default behavior. If we get feedback that it's confusing to folks-- then we can adjust.

[dwhly]

@sheetaluk (per our slack chat yesterday):

I wonder if we could show the empty annotations tab, but explicitly say something like "There are no annotations, but click here to view all 'n' page notes." or something along those lines, in addition to the page notes tab and the count right next to it.

Let's just go ahead and show the page notes tab. If anything you could alert in reverse "There were no annotations, only the page notes above". But perhaps that should be based on user feedback?

On page load default to annotations tab if there are annotations, otherwise page notes if there are page notes.

Yes.

If there are no annotations or page notes, default to the annotations tab.

Yes.

If a user has made a tab selection of annotation or notes and changes a group, carry over the tab selection on group change.

I'm not so sure about this one-- I think we should just stick w/ the default behavior you've scoped out above vs having the sticky tab selection. Since it's extra code & complexity-- lets wait until we get clear feedback to the contrary. Not apparent to me that stickiness here would be the intuitive thing.

If a user has selected the annotations tab and switches to a group which has no annotations but has page notes <what do we do?>

Same as above. Default behavior is that if there are no annotations but there are page notes, then show the page notes.

Similarly, if a user has selected the page notes tab and switches to a group which has no notes but only annotations, <what do we do?>

Annotations tab. Per above.

If a user has selected the orphans tab and changes group or reloads the page, <what do we do?>

Per above. Use the default behavior.

If a user lands on a direct link which is an orphaned annotation, on clearing the selection, what tab should they default to?

Interesting question. The simplest thing would be to show all orphans, which presumably is the default behavior. If we get feedback that it's confusing to folks-- then we can adjust.