Permalink
Comparing changes
Open a pull request
- 6 commits
- 6 files changed
- 3 commit comments
- 1 contributor
Showing
with
16 additions
and 10 deletions.
Showing you all comments on commits in this comparison.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Shouldn't we make the same change to the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
aron
Jan 29, 2015
Contributor
Guest uses an event bus with a different API.
// Annotator Events
this.subscribe(eventName, function (a, b, c) {})
this.publish(eventName, [a, b, c])
// Angular Events
$scope.$on(eventName, function (event, a, b, c) {})
$scope.$emit(eventName, a, b, c)
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Treora
Jan 29, 2015
Contributor
Hmm indeed.. somehow I thought they also passed an event object. My bad.
|
Hmm indeed.. somehow I thought they also passed an event object. My bad. |
Shouldn't we make the same change to the
onfunction inguest.coffee?