Fix handling of holes in threads

[gergely-ujvari]

This first part has been fixed. See below for bug description.

Currently if you sort by the viewer by Newest and if you have a hole annotation (Saying message not available) then this climbs at the top, because of our sorting alg.

This is not ideal because I want my most recently created annotations to be in top.

---

EDITED by @tilgovi

The stream also has holes when replies load before parents. We should probably do something smarter here like show the replies and load the parents on click, something like what Twitter is doing.

• Preserve holes in threads
• Style the holes and decide what to show
• Decide how and when to attempt to load more context in the stream moved to #1713

[tilgovi]

Changing the title of this to "Holes in threads".

[tilgovi]

Changing the title of this to "Holes in threads".

[tilgovi]

"Design behavior when threads have holes" is what I went with.

[tilgovi]

"Design behavior when threads have holes" is what I went with.

[tilgovi]

Just want to call out my comment in #1525 as particularly relevant for anyone tackling this. #1525 (comment)

[tilgovi]

Just want to call out my comment in #1525 as particularly relevant for anyone tackling this. #1525 (comment)

[JakeHartnell]

This bug is even more annoying on the stream, we have 2 annotations that just sit at the top now even though they were made awhile ago:

You can see this live on https://hypothes.is/stream

We should probably tackle this quickly, since deleted "Message Not Available" annotations push down everything else on the stream.

[JakeHartnell]

This bug is even more annoying on the stream, we have 2 annotations that just sit at the top now even though they were made awhile ago:

You can see this live on https://hypothes.is/stream

We should probably tackle this quickly, since deleted "Message Not Available" annotations push down everything else on the stream.

[JakeHartnell]

Part of this has been addressed by 5a5368b, annotations are no longer piled on top of the stream.

[JakeHartnell]

Part of this has been addressed by 5a5368b, annotations are no longer piled on top of the stream.

[aron]

Could someone give me an up-to-date summary of this ticket and steps to reproduce the remaining to-dos. Currently I only have the proposed solution to #1525 to go on. /cc @gergely-ujvari

[aron]

Could someone give me an up-to-date summary of this ticket and steps to reproduce the remaining to-dos. Currently I only have the proposed solution to #1525 to go on. /cc @gergely-ujvari

[aron]

I'm breaking this ticket up, to leave this one just dealing with bugs around holes in the thread across the application.

I've moved the issue of how we deal with conversations in the stream to #1713. This can encompass #1644 and #1712. I think we need to take a more detailed look at the stream what it's supposed to be doing compared to what it's currently doing and go from there.

[aron]

I'm breaking this ticket up, to leave this one just dealing with bugs around holes in the thread across the application.

I've moved the issue of how we deal with conversations in the stream to #1713. This can encompass #1644 and #1712. I think we need to take a more detailed look at the stream what it's supposed to be doing compared to what it's currently doing and go from there.