Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angularjs to 1.3.x #1631

Closed
gergely-ujvari opened this issue Nov 4, 2014 · 3 comments

Comments

Projects
None yet
4 participants
@gergely-ujvari
Copy link
Contributor

commented Nov 4, 2014

Our current angularjs version (1.2.25) is legacy, so we should do the upgrade.
Also Angularjs 1.3.x has some new nice features we may use in the future.

@gergely-ujvari gergely-ujvari changed the title Upgrade angularjs to 1.3.1 Upgrade angularjs to 1.3.x Nov 18, 2014

@gergely-ujvari

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2014

I've tried to run our current code with anguljarjs 1.3 and it breaks our formInput directive here: https://github.com/hypothesis/h/blob/master/h/static/scripts/helpers/form-helpers.coffee#L17

The validator it receives is an empty dict {}, instead of the dict with the three functions defined in the formValidate directive here: https://github.com/hypothesis/h/blob/master/h/static/scripts/helpers/form-helpers.coffee#L50

I do not see trivially why is this, so it'll take time to figure this out. (And all other things coming after this is resolved)

@gergely-ujvari

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2015

For the record we upgraded angularjs to the latest 1.2.x version, namely 1.2.28

@robertknight

This comment has been minimized.

Copy link
Member

commented Oct 22, 2015

Angular has been upgraded to 1.4.7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.