New annotations don't appear to have keyboard focus (until you start typing)

[seanh]

When the user creates a new annotation the sidebar automatically scrolls to show it, but the keyboard focus is not always automatically in the new annotation's text area. Sometimes it is, sometimes it isn't.

[JakeHartnell]

I can't reproduce this. Any steps to preform or a site where this happens?

[JakeHartnell]

I can't reproduce this. Any steps to preform or a site where this happens?

[seanh]

Hmm, I really have seen this lots of times, but now I can't figure out how to reproduce it on master. Closing for now

[seanh]

Hmm, I really have seen this lots of times, but now I can't figure out how to reproduce it on master. Closing for now

[edrex]

Input focus isn't set to the new annotation text field for me (ever).

Chrome 45.0.2454.93 OS X, using the chrome browser app.

This costs a scan/seek/click cycle, which the user really feels IMO, after clicking the extension button, waiting for the overlay to load, finding and clicking the "New Note" button.

Auto-scrolling to the new annotation works.

Should I report this as a new issue or would reopening this make sense?

[edrex]

Input focus isn't set to the new annotation text field for me (ever).

Chrome 45.0.2454.93 OS X, using the chrome browser app.

This costs a scan/seek/click cycle, which the user really feels IMO, after clicking the extension button, waiting for the overlay to load, finding and clicking the "New Note" button.

Auto-scrolling to the new annotation works.

Should I report this as a new issue or would reopening this make sense?

[dwhly]

While the bootstrappy blue border isn't active on the text edit box, if you start typing you should see that the actual focus is on the element. We should fix the first, but just checking that you're seeing that the focus is indeed set correctly.

[dwhly]

While the bootstrappy blue border isn't active on the text edit box, if you start typing you should see that the actual focus is on the element. We should fix the first, but just checking that you're seeing that the focus is indeed set correctly.

[edrex]

Ah, when I start typing the focus is switched to the new annotation input box, but I think the focus should be set when the note is created so focus cues work.

[edrex]

Ah, when I start typing the focus is switched to the new annotation input box, but I think the focus should be set when the note is created so focus cues work.

[seanh]

Yep, I can reproduce it as @dwhly and @edrex say on master: text area does not appear to be focused but if you start typing it is. Re-opening

[seanh]

Yep, I can reproduce it as @dwhly and @edrex say on master: text area does not appear to be focused but if you start typing it is. Re-opening

[tilgovi]

@seanh not sure that's fixable, since it's probably UA / OS dependent. I don't know of any way to change the focus to the iframe, just set the focused within the frame. If the OS doesn't show a background window/frame as having focus, it may not be possible.

[tilgovi]

@seanh not sure that's fixable, since it's probably UA / OS dependent. I don't know of any way to change the focus to the iframe, just set the focused within the frame. If the OS doesn't show a background window/frame as having focus, it may not be possible.

[edrex]

Ah, I suspected there might be some iframe-related reason it worked this way. that's a bummer. It would be best if the focus could be set immediately. What is it that allows changing the focused frame on keystroke but not on create? Otherwise, maybe some class manipulation + style rule to visually highlight it (although that wouldn't help screen readers etc)?

[edrex]

Ah, I suspected there might be some iframe-related reason it worked this way. that's a bummer. It would be best if the focus could be set immediately. What is it that allows changing the focused frame on keystroke but not on create? Otherwise, maybe some class manipulation + style rule to visually highlight it (although that wouldn't help screen readers etc)?

[edrex]

Tried to create a test case, but I'm not sure if I'm replicating the conditions for the extension correctly. Autofocus in the newly created frame works there.

http://codepen.io/edrex/pen/dYpyov

[edrex]

Tried to create a test case, but I'm not sure if I'm replicating the conditions for the extension correctly. Autofocus in the newly created frame works there.

http://codepen.io/edrex/pen/dYpyov

[tilgovi]

If I understand correctly, the focus is there, and at least the browser knows, and maybe directs the key events properly, but the OS might not and therefore the text area widget might not show the blinking beam cursor or whatever until you type or otherwise force the focus over there. I'm just speculating. If it has to do with the cursor style in a "background" window, that's not something I think we have any styling control over.

[tilgovi]

If I understand correctly, the focus is there, and at least the browser knows, and maybe directs the key events properly, but the OS might not and therefore the text area widget might not show the blinking beam cursor or whatever until you type or otherwise force the focus over there. I'm just speculating. If it has to do with the cursor style in a "background" window, that's not something I think we have any styling control over.

[nickstenning]

Fixed by #3041.

[nickstenning]

Fixed by #3041.