Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless URL displayed for PDF annotations #2178

Closed
csillag opened this issue Apr 18, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@csillag
Copy link
Contributor

commented Apr 18, 2015

When a PDF annotation appears on the stream page, for the source, we are displaying links like this one:

source

Technically, the x-pdf URN-s are generated from the PDF fingerprints, and they are indeed useful for the system to identify different copies of the same document, but it makes no sense whatsoever to display these links in a web page. In fact, we used to have code to specifically avoid displaying these, and show the file-based URLs instead.

Maybe we have stopped storing the file paths for PDFs since that; but in that case, maybe we simply shouldn't display any clickable source links for PDFs? (I guess no link is better than a broken link.)

@csillag

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2015

we are displaying links like this one:

source

Looks like github won't identify a URL using an unknown protocol as a real link, so here is the URL, copied verbatim:

unsafe:urn:x-pdf:4d729513b8c25fc4f87ae4ec47952fda

(instead of something like http:// or file:// )

@tilgovi

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2015

Similar to #2062

@seanh

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2015

Can't reproduce

@seanh seanh closed this Sep 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.