Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-break Annotator (broken by integrating Fuzzy) #295

Closed
csillag opened this issue Mar 5, 2013 · 2 comments
Closed

Un-break Annotator (broken by integrating Fuzzy) #295

csillag opened this issue Mar 5, 2013 · 2 comments
Assignees

Comments

@csillag
Copy link
Contributor

csillag commented Mar 5, 2013

The annotator has only been tested as part of h. Although the source code now references dom-text-mapper, the code to initialize ans set it up correctly is missing from Annotator. (It's inside h.) If we want to push our changes upstream (and I guess we do), then we must un-break annotator.

@ghost ghost assigned csillag Mar 22, 2013
@csillag
Copy link
Contributor Author

csillag commented Apr 12, 2013

Work is done on this branch:

https://github.com/hypothesis/annotator/tree/unbreak-standalone

@csillag
Copy link
Contributor Author

csillag commented Sep 19, 2013

So, this has been done a loong time ago. Closing.
(What remains to be done is adding test cases, but that's a different issue.)

@csillag csillag closed this as completed Sep 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant