Small ux improvements #2330

Merged
merged 3 commits into from Jun 19, 2015

Projects

None yet

4 participants

@JakeHartnell
Contributor

There are 3 small things in this PR:

  1. Kill note icon on card: It was the same as the icon for make new note... which was confusing, and arguably did little to help people understand what was going on. We obviously still need something else with regards to distinguishing page comments, but that's a separate issue.
    Comment, without note icon
  2. Slightly more padding on menus: with mobile I like to have more padding on the menus so that it is easier to select things with my big fingers on a small screen.
    More padding on menus
  3. Adding a tooltip to the highlight icon:
    Tooltip on card highlight icon

Thoughts? Hopefully these aren't too controversial.

@landscape-bot

Code Health
Repository health decreased by 0.01% when pulling b97c7d9 on small-UX-improvements into d17ed5a on master.

@judell
Contributor
judell commented Jun 19, 2015

+1 for the tooltip. FWIW I'd like us to use them everywhere possible. Here, for example, we could say on the lock icon "Private Note"

@tilgovi tilgovi commented on an outdated diff Jun 19, 2015
h/templates/client/annotation.html
@@ -9,8 +9,7 @@
ng-href="{{vm.baseURI}}u/{{vm.annotation.user}}"
>{{vm.annotation.user | persona}}</a>
<i class="h-icon-lock" ng-show="vm.isPrivate() && !vm.editing"></i>
- <i class="h-icon-border-color" ng-show="vm.isHighlight() && !vm.editing"></i>
- <i class="h-icon-insert-comment" ng-show="vm.isComment()"></i>
+ <i class="h-icon-border-color" ng-show="vm.isHighlight() && !vm.editing" title="This is a highlight, click 'edit' to add a note or tag."></i>
@tilgovi
tilgovi Jun 19, 2015 Contributor

grammar note: should have a semicolon or a period, not a comma.

@tilgovi
tilgovi Jun 19, 2015 Contributor

Of course I reply with no capitalization and with the same mistake. ;)

@JakeHartnell JakeHartnell Tooltip on highlight icon.
641f1aa
@JakeHartnell
Contributor

Ok. Grammar updated. : )

+1 for the tooltip. FWIW I'd like us to use them everywhere possible. Here, for example, we could say on the lock icon "Private Note"

I'm addressing this in: #2322

@landscape-bot

Code Health
Repository health decreased by 0.01% when pulling 641f1aa on small-UX-improvements into d17ed5a on master.

@tilgovi tilgovi merged commit c9aa105 into master Jun 19, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tilgovi tilgovi deleted the small-UX-improvements branch Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment