Atom feed link tweaks #2338

Merged
merged 3 commits into from Jul 3, 2015

Projects

None yet

3 participants

@BigBlueHat
Contributor

Hopefully fixing some <link rel=""> issues with the Atom feed.

I chose to use the URI for oa:hasTarget as the rel value for the annotated resource. It's the most accurate link relation I could find. ๐Ÿ˜ธ

If someone could give this a quick test run too, I'd appreciate it...my h dev environs are still a tangle...

Thanks!

@tilgovi
Contributor
tilgovi commented Jul 2, 2015

Ping this back after you change the rel.

@BigBlueHat
Contributor

@tilgovi did you want me to switch to outputting all the values from target.*.source? or just stick with annotation.uri for now?

@tilgovi
Contributor
tilgovi commented Jul 2, 2015

@BigBlueHat that'd be ideal!

@judell
Contributor
judell commented Jul 2, 2015

Thanks for this @BigBlueHat.

It'd be nice to also address #2329 so I can test both of these things together. The combo will unblock a blog post I've been meaning to write.

As a reminder, the user story here is RSS widgets (e.g. on WordPress) that want to link to annotation.uri instead of (or in addition to) the bare annotation. So from that perspective. annotation.uri alone should be fine for now.

@BigBlueHat
Contributor
@tilgovi
Contributor
tilgovi commented Jul 2, 2015

Your wish is my command @judell: 653f19e

@judell
Contributor
judell commented Jul 2, 2015

Excellent, thanks gents.

@BigBlueHat
Contributor

K. That should be ready also. Switched from the hasTarget URL to related as the rel.

BigBlueHat and others added some commits Jun 30, 2015
@BigBlueHat @tilgovi BigBlueHat Reference annotated resource using rel=related
Also made type attribute conditional on link
in the atom.xml file--as it is technically optional

Used target.*.source, so multiple targets will
be output in the future multi-target awesomeness.

Fixes #2280
f1b25d1
@tilgovi tilgovi Atom feed should not choke on lack of targets f7af922
@tilgovi tilgovi Add tests for targets in atom feed
a296188
@tilgovi
Contributor
tilgovi commented Jul 3, 2015

@BigBlueHat I covered for you this time, but next time tests please :).

@tilgovi tilgovi merged commit c6be6c1 into master Jul 3, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tilgovi tilgovi deleted the atom-feed-link-tweaks branch Jul 3, 2015
@BigBlueHat
Contributor

Thanks! Sorry I forgot those. Next time! ๐Ÿ˜ƒ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment