Prevent annotation attempts when not signed in #2361

Merged
merged 1 commit into from Jul 15, 2015

Projects

None yet

4 participants

@BigBlueHat
Contributor

Simply hides the annotation form--which implied you could
use the thing...--and instead tells the user to sign in,
so they can do what they came to do.

Works like this: ๐ŸŽฅ https://youtu.be/KC4NmHZJea8

Obviously room for improvement, but so much better than what we've been doing.

Cheers!

@BigBlueHat BigBlueHat Prevent annotation attempts when not signed in
Simply hides the annotation form--which implied you could
use the thing...--and instead tells the user to sign in,
so they can do what they came to do.
062a4d8
@judell
Contributor
judell commented Jul 14, 2015

Thanks Benjamin!

@judell
Contributor
judell commented Jul 14, 2015

BTW I'm happy to walk you through the dokku procedure if you want to spin one up for this.

@JakeHartnell
Contributor

This a great quick fix! LGTM ๐Ÿ‘

@JakeHartnell JakeHartnell merged commit a70fa5f into master Jul 15, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 58.465%
Details
@JakeHartnell JakeHartnell deleted the prevent-annotation-attempt-when-not-signed-in branch Jul 15, 2015
@judell
Contributor
judell commented Jul 15, 2015

Thanks!

@judell
Contributor
judell commented Jul 15, 2015

The behavior on stage doesn't match the screencast. What changed? Now the annotation appears, with an embedded "You must sign in" message, but the Sign In link isn't live until the annotation is canceled.

@BigBlueHat
Contributor

@judell doesn't look like stage has this patch yet.

@tilgovi
Contributor
tilgovi commented Jul 15, 2015

Correct

@judell
Contributor
judell commented Jul 20, 2015

Checks out on stage now, thx.

@judell
Contributor
judell commented Jul 22, 2015

I switched browsers today while testing. Thanks to this, I avoided losing data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment