Share a group #2412

Merged
merged 1 commit into from Aug 6, 2015

Projects

None yet

3 participants

@seanh
Contributor
seanh commented Jul 29, 2015

This is the second pull request for the groups feature.

What's in here:

  • If you visit a group's page when you're not logged-in it tells you what group this is and gives you a link to login in order to join
  • If you are logged-in it gives you a button to join the group. Clicking this button adds you to the group in the db and reloads the page.
  • If you are already a member it tells you so and gives you a link to copy and share with others in order to invite them
  • "You've joined" flash message
  • Needless to say some design polish is needed for these pages.
  • The login link just opens /login in a new tab. After logging in or registering and activating you have to go back to the original tab and refresh it. It doesn't attempt to take you to the login page within the one tab and then have it redirect back to the group's page after login, because that doesn't work for people who need to register, activate, possibly install the extension. More onboarding flow design work is needed here.
  • There are two links to the group's page in the groups dropdown in the sidebar: both the group's name and the "link" icon link to it. This is because in the future the group's name will become a button for focusing the sidebar on that group instead.
@seanh
Contributor
seanh commented Jul 31, 2015

@tilgovi This one is a couple of days old, also ready for review, just did a massive rebase onto the latest master

Sean Hammond Implement "Share a group" functionality
Group pages show a "Login to join group" link (opens in a new tab) if
you're not logged in.
If you're logged in they show a "Click to join group" button, posts to
new join() callable that adds the user to the group.
If you're already a member they show a "Share this link to invite people" link.

The groups dropdown list has new share icon links to the group's page,
for each group.
429ef77
@seanh
Contributor
seanh commented Aug 5, 2015

Rebased onto latest master

@landscape-bot

Code Health
Repository health increased by 0.16% when pulling 429ef77 on share-a-group into 9f5674f on master.

@nickstenning
Member

LGTM.

@nickstenning nickstenning merged commit acab2e1 into master Aug 6, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 63.546%
Details
@nickstenning nickstenning deleted the share-a-group branch Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment