Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2440 replies dont match search normalized url queries 2 #2477

Merged

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Sep 2, 2015

Fixes #2440.

And make it a list of strings instead of a single string, and make it
public.
Copy annotation.target.scope from parent annotations into reply
annotations in prepare(). This means that replies show up in searches
for annotations of a given URI (searches for annotations with a given
URI in their scopes), such as when viewing the annotations of a page in
the sidebar, when the search_normalized feature is active.
@seanh seanh mentioned this pull request Sep 2, 2015
@seanh
Copy link
Contributor Author

seanh commented Sep 2, 2015

Ready for review

tilgovi added a commit that referenced this pull request Sep 2, 2015
…ch-normalized-url-queries-2

2440 replies dont match search normalized url queries 2
@tilgovi tilgovi merged commit 4f14c58 into master Sep 2, 2015
@tilgovi tilgovi deleted the 2440-replies-dont-match-search-normalized-url-queries-2 branch September 2, 2015 17:09
@tilgovi
Copy link
Contributor

tilgovi commented Sep 2, 2015

I merged this because with our current web client everything should work as expected. I opened #2479 and #2480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants