Set group and visibility of reply to that of parent

[seanh]

Set the group and visibility of replies to that of their parents, when
replies are first created.

Also prevent the visibility setting of a reply from overwriting the
cached-in-local-storage visibility level. This prevents the following
problem:

• I'm annotating publicly (my cached-in-local-storage visibility
  setting is public)
• I reply to a private annotation
• The visibility of my reply is set to that of its parent, private
• This visibility is then cached in local storage
• I make a new top-level annotation, and now it's defaulting to private
  instead of public, even though the user never did anything to change
  the visibility from public to private, it was done automatically
  because they replied to a private annotation.

Obviously changing the mode from private to public when replying to a
public annotation was also possible.

This means that if the user does change the visibility of a reply, we
don't cache that either:

• I'm annotating publicly (my cached-in-local-storage visibility
  setting is public)
• I reply to a public annotation
• The visibility of my reply is set to that of its parent, public
• This visibility is not cached in local storage because it's a reply
  (and the value cached in the local storage is already the same anyway)
• I then deliberately change the visibility of my reply from public to
  private
• Again this visibility is not cached in local storage because it's a reply
• The next time I make a new top-level annotation, it will still be
  defaulting to public, will not have changed to private mode

[seanh]

When I reply to an annotation, my reply should go to the same group and have the same visibility

[seanh]

When I reply to an annotation, my reply should go to the same group and have the same visibility

[seanh]

This is done, who wants to review it? @nickstenning @robertknight

[seanh]

This is done, who wants to review it? @nickstenning @robertknight

[seanh]

This should also fix the problem with replying in the stream. No matter what group you had focused last time you used the sidebar, replies in the stream should get the same group as their parents

[seanh]

This should also fix the problem with replying in the stream. No matter what group you had focused last time you used the sidebar, replies in the stream should get the same group as their parents

[nickstenning]

This looks great. Nice and clean. One minor thing: the publish-annotation-btn directive no longer needs an isNew param, so that can be removed (from the directive, its tests, and annotation.html).

[nickstenning]

This looks great. Nice and clean. One minor thing: the publish-annotation-btn directive no longer needs an isNew param, so that can be removed (from the directive, its tests, and annotation.html).

[robertknight]

here are only two cases here so it doesn't make much difference, but in general I prefer that when you have several tests with very similar logic, they be expressed as:

var cases = [...]
cases.forEach(function (case) {
it('does something for case ' + case.name, function () {
  // create variant using the case
});
}

[robertknight]

LGTM - Just the trivial comment nick mentioned.

[robertknight]

LGTM - Just the trivial comment nick mentioned.