Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not update the group for existing annotations on edit #2911
+3
−15
Conversation
added a commit
that referenced
this pull request
Feb 3, 2016
seanh
merged commit e799a15
into
master
Feb 3, 2016
seanh
deleted the
fix-group-annot-edit-from-stream
branch
Feb 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
robertknight commentedFeb 3, 2016
Whenever an annotation was edited, its current group
was set to whichever group was focused in the UI.
Our current model does not allow for moving annotations
between groups however. The only time when annotations
should have their groups set is when the annotation
is newly created and when switching groups before saving
the annotation. We already have separate logic to deal
with both of these cases.
Fixes #2902