Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace "firstRun" config option with "openSidebar" and "openLoginForm" #3643
Conversation
nickstenning
referenced this pull request
Aug 1, 2016
Merged
Replace "firstRun" config option with "openSidebar" and "openLoginForm" #63
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
chdorner
Aug 3, 2016
Contributor
LGTM. Will try and get this out to production today without making a new release.
|
LGTM. Will try and get this out to production today without making a new release. |
chdorner
merged commit 1939ebe
into
master
Aug 3, 2016
chdorner
deleted the
remove-firstrun-config-option
branch
Aug 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nickstenning commentedAug 1, 2016
This commit deprecates the confusingly-named "firstRun" embed script
option with two which actually describe the relevant actions triggered.
I've left the "firstRun" option around for now, for old(er) clients. We
can remove this in due course, as noted in a template comment.