Retry mailer tasks on SMTP failure #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing evidence that occasionally the Mandrill SMTP server disconnects our mailer, or perhaps that the network between our application and Mandrill occasionally drops: https://sentry.io/hypothesis/prod/issues/152186124/ This commit adds retry logic to the mailer task to ensure that in the event of any kind of network or SMTP error, the task is requeued for another delivery attempt later. With the current configuration we will attempt to deliver mail four times (i.e. 3 retries) over a period of approximately 20 minutes, using an exponential backoff.
Current coverage is 77.60% (diff: 100%)@@ master #3823 diff @@
==========================================
Files 150 150
Lines 5562 5568 +6
Methods 0 0
Messages 0 0
Branches 618 618
==========================================
+ Hits 4315 4321 +6
+ Misses 1175 1173 -2
- Partials 72 74 +2
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing evidence that occasionally the Mandrill SMTP server disconnects our mailer, or perhaps that the network between our application and Mandrill occasionally drops:
https://sentry.io/hypothesis/prod/issues/152186124/
This commit adds retry logic to the mailer task to ensure that in the event of any kind of network or SMTP error, the task is requeued for another delivery attempt later.
With the current configuration we will attempt to deliver mail four times (i.e. 3 retries) over a period of approximately 20 minutes, using an exponential backoff.