New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki: Move the section on 'source clone' up #4402

Merged
merged 2 commits into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@jccr
Contributor

jccr commented Mar 3, 2017

Clarify use of docker-compose up for the website install steps

Move the section on source clone up
Clarify use of `docker-compose up`
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 3, 2017

Codecov Report

Merging #4402 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4402   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         320      320           
  Lines       18173    18173           
  Branches     1074     1074           
=======================================
  Hits        17130    17130           
  Misses        935      935           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e9b08...27ecc32. Read the comment docs.

codecov-io commented Mar 3, 2017

Codecov Report

Merging #4402 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4402   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         320      320           
  Lines       18173    18173           
  Branches     1074     1074           
=======================================
  Hits        17130    17130           
  Misses        935      935           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e9b08...27ecc32. Read the comment docs.

@robertknight

Thanks for the correction @jccr . As noted on Slack, the introduction needs a small correction to clarify that readers should move on to 'Getting the h source code' after installing system dependencies. Otherwise looks good.

Clarify the introduction section
The referenced sections were shuffled around
@robertknight

This comment has been minimized.

Show comment
Hide comment
@robertknight

robertknight Mar 3, 2017

Contributor

LGTM. Thank-you!

Contributor

robertknight commented Mar 3, 2017

LGTM. Thank-you!

@robertknight robertknight merged commit 69792c5 into hypothesis:master Mar 3, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 78e9b08...27ecc32
Details
codecov/project 94.26% remains the same compared to 78e9b08
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment