Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to cryptography 1.8 #4484
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nickstenning
Apr 5, 2017
Contributor
We can ignore the safety-ci status check here, as we can fix that in subsequent PRs.
|
We can ignore the safety-ci status check here, as we can fix that in subsequent PRs. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov-io
Apr 5, 2017
Codecov Report
Merging #4484 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #4484 +/- ##
======================================
Coverage 94.6% 94.6%
======================================
Files 354 354
Lines 18859 18859
Branches 1088 1088
======================================
Hits 17842 17842
Misses 905 905
Partials 112 112Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 3e900fe...d7ae1ed. Read the comment docs.
codecov-io
commented
Apr 5, 2017
Codecov Report
@@ Coverage Diff @@
## master #4484 +/- ##
======================================
Coverage 94.6% 94.6%
======================================
Files 354 354
Lines 18859 18859
Branches 1088 1088
======================================
Hits 17842 17842
Misses 905 905
Partials 112 112Continue to review full report at Codecov.
|
chdorner
approved these changes
Apr 5, 2017
As mentioned in Slack, I've tested being logged in on master, then checked out this branch and installed the packages and made sure that I'm still logged in.
nickstenning commentedApr 5, 2017
Upgrade to the latest cryptography, mainly to ensure that we're staying current with security-critical libraries.
In particular, we appear to have entirely missed that cryptography 1.5.3 contained a security fix for an issue with HKDF, which we use for key derivation (CVE-2016-9243).