New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CLI commands for user: password, delete #4511

Merged
merged 2 commits into from Apr 10, 2017

Conversation

Projects
None yet
3 participants
@mgax
Copy link
Contributor

mgax commented Apr 7, 2017

No description provided.

mgax added some commits Apr 7, 2017

@mgax mgax force-pushed the mgax:cli-user-pw-del branch from 4e9f09b to fc62ea7 Apr 7, 2017

@mgax

This comment has been minimized.

Copy link
Contributor Author

mgax commented Apr 7, 2017

Ah, I was working off an old version, and the API for passwords has changed. Should be fixed now.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 7, 2017

Codecov Report

Merging #4511 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4511      +/-   ##
==========================================
+ Coverage   94.33%   94.36%   +0.02%     
==========================================
  Files         355      355              
  Lines       19080    19175      +95     
  Branches     1106     1110       +4     
==========================================
+ Hits        18000    18095      +95     
  Misses        980      980              
  Partials      100      100
Impacted Files Coverage Δ
tests/h/cli/commands/user_test.py 100% <100%> (ø) ⬆️
h/cli/commands/user.py 94.2% <100%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc0257...fc62ea7. Read the comment docs.

@nickstenning

This comment has been minimized.

Copy link
Contributor

nickstenning commented Apr 10, 2017

LGTM. The only slight query I have is around use of the full UserPasswordService (rather than a stub) in the tests, but it's not a big deal.

@nickstenning nickstenning merged commit f141e24 into hypothesis:master Apr 10, 2017

4 checks passed

codecov/patch 100% of diff hit (target 94.33%)
Details
codecov/project 94.36% (+0.02%) compared to fcc0257
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!

@mgax mgax deleted the mgax:cli-user-pw-del branch Apr 12, 2017

@mgax

This comment has been minimized.

Copy link
Contributor Author

mgax commented Apr 12, 2017

Cool, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment