Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute selection language and attribute sync bug #40

Merged
merged 2 commits into from Jul 30, 2016
Merged

Fix attribute selection language and attribute sync bug #40

merged 2 commits into from Jul 30, 2016

Conversation

@TeemuSuoranta
Copy link
Contributor

@TeemuSuoranta TeemuSuoranta commented Jul 5, 2016

The fix for the issue #26. Also makes selectable attributes be in the same language as the product when creating a new product.

@decarvalhoaa
Copy link
Contributor

@decarvalhoaa decarvalhoaa commented Jul 6, 2016

Hey Teemu,

thanks for that. Apologies of my ignorance in advance, do you know how to merge your changes from here or your repo to my fork?

@TeemuSuoranta
Copy link
Contributor Author

@TeemuSuoranta TeemuSuoranta commented Jul 6, 2016

Hi!

Can't say that I've done it before, either. You should merge this pull request I made directly to your fork decarvalhoaa#17 instead of this one that's made for Hyyan's version.

I found a tutorial here that should help: https://help.github.com/articles/merging-a-pull-request/

My fork of the plugin is becoming a mess of branches because I need to create a new branch for every pull request. By merging you might get my branch there too, but the tutorial shows how to get rid of it.

@hyyan hyyan self-assigned this Jul 30, 2016
@hyyan hyyan merged commit cec6468 into hyyan:master Jul 30, 2016
@hyyan
Copy link
Owner

@hyyan hyyan commented Jul 30, 2016

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants