Permalink
Browse files

o remove debug ui feature. Not really used and disabled for a while.

  • Loading branch information...
1 parent cf8ddb8 commit 39fece1a6f786b2104d3cd58e3aa3c4fa886b6f0 @hzeller committed Oct 6, 2012
Showing with 3 additions and 18 deletions.
  1. +1 −1 folve-filesystem.cc
  2. +0 −4 folve-filesystem.h
  3. +1 −3 folve-main.cc
  4. +0 −8 status-server.cc
  5. +1 −2 status-server.h
View
2 folve-filesystem.cc
@@ -538,7 +538,7 @@ class SndFileHandler :
} // namespace
FolveFilesystem::FolveFilesystem()
- : debug_ui_enabled_(false), gapless_processing_(false),
+ : gapless_processing_(false),
open_file_cache_(4), processor_pool_(3),
total_file_openings_(0), total_file_reopen_(0) {
}
View
4 folve-filesystem.h
@@ -87,9 +87,6 @@ class FolveFilesystem {
FileHandlerCache *handler_cache() { return &open_file_cache_; }
ProcessorPool *processor_pool() { return &processor_pool_; }
- void set_debug_ui_enabled(bool b) { debug_ui_enabled_ = b; }
- bool is_debug_ui_enabled() const { return debug_ui_enabled_; }
-
void set_gapless_processing(bool b) { gapless_processing_ = b; }
bool gapless_processing() const { return gapless_processing_; }
@@ -120,7 +117,6 @@ class FolveFilesystem {
std::string base_config_dir_;
std::string current_config_subdir_;
- bool debug_ui_enabled_;
bool gapless_processing_;
FileHandlerCache open_file_cache_;
ProcessorPool processor_pool_;
View
4 folve-main.cc
@@ -252,14 +252,12 @@ int FolveOptionHandling(void *data, const char *arg, int key,
if (config_dir != NULL) {
rt->fs->SetBaseConfigDir(config_dir);
} else {
- fprintf(stderr, "Invalid config dir '%s': %s\n",
- arg + 2, strerror(errno));
+ fprintf(stderr, "Invalid config dir '%s': %s\n", arg + 2, strerror(errno));
rt->parameter_error = true;
}
return 0;
}
case FOLVE_OPT_DEBUG:
- // rt->fs->set_debug_ui_enabled(true); // Disabled in status-server.
folve::EnableDebugLog(true);
return 0;
case FOLVE_OPT_GAPLESS:
View
8 status-server.cc
@@ -112,8 +112,6 @@ int StatusServer::HandleHttp(void* user_argument,
if (strcmp(url, kSettingsUrl) == 0) {
server->SetFilter(MHD_lookup_connection_value(connection,
MHD_GET_ARGUMENT_KIND, "f"));
- server->SetDebug(MHD_lookup_connection_value(connection,
- MHD_GET_ARGUMENT_KIND, "d"));
// We redirect to slash after this, to remove parameters from the GET-URL
response = MHD_create_response_from_data(0, (void*)"", MHD_NO, MHD_NO);
MHD_add_response_header(response, "Location", "/");
@@ -146,11 +144,6 @@ void StatusServer::SetFilter(const char *filter) {
filter_switched_ = filesystem_->SwitchCurrentConfigDir(filter);
}
-void StatusServer::SetDebug(const char *dbg) {
- if (!filesystem_->is_debug_ui_enabled()) return;
- folve::EnableDebugLog(dbg != NULL && *dbg == '1');
-}
-
bool StatusServer::Start(int port) {
daemon_ = MHD_start_daemon(MHD_USE_SELECT_INTERNALLY, port, NULL, NULL,
&HandleHttp, this,
@@ -313,7 +306,6 @@ void StatusServer::AppendSettingsForm() {
"Affects re- or newly opened files.</span>");
filter_switched_ = false; // only show once.
}
- // TODO: re-add something for filesystem_->is_debug_ui_enabled()
content_.append("</p><hr style='clear:both;'/>");
}
View
3 status-server.h
@@ -55,9 +55,8 @@ class StatusServer : protected FileHandlerCache::Observer {
void AppendSettingsForm();
void AppendFileInfo(const char *progress_style, const HandlerStats &stats);
- // Set filter or debug mode from http-request. Gracefully handles garbage.
+ // Set filter from http-request. Gracefully handles garbage.
void SetFilter(const char *value);
- void SetDebug(const char *value);
// Show details that might only be interesting while setting up things.
bool show_details();

0 comments on commit 39fece1

Please sign in to comment.