Allow authorization events to include multiple x tags #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK. This seems like a reasonable change to the protocol to improve efficiency in clients fetching from blossom servers. I've tried to theorize on possible attacks introduced from this change but haven't been able to find any issues thus far. I've been mostly thinking about DOS related attacks. |
|
Under my point of view it is correct, we minimize unnecessary events, especially thinking in batch file uploads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the wording in BUD-01 and BUD-02 to allow
upload,get, anddeleteauthorization events to have multiplextagsThis would allow clients to use a single authorization event for multiple
PUT /uploadorDELETE /<sha256>requestsWhen multiple
xtags are present on an authorization event sent to theDELETE /<sha256>orPUT /mirrorendpoints, it MUST NOT be interpreted as a bulk delete or bulk mirror