Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opencensus Module sets X-Correlation-Id even if already present #304

Closed
nico-i opened this issue Dec 8, 2022 · 1 comment
Closed

Opencensus Module sets X-Correlation-Id even if already present #304

nico-i opened this issue Dec 8, 2022 · 1 comment

Comments

@nico-i
Copy link
Contributor

nico-i commented Dec 8, 2022

Description

Currently the open census module adds a correlation id header and value to every HTTP request. This leads to problems in our project as we already use the X-Correlation-Id header in other contexts throughout our services.

Proposed solution

To deal with this issue I suggest to modify the corresponding module.go to only set the X-Correlation-Id header if it isn't already present and to instead use the existing X-Correlation-Id value if it is.

Acknowledgements

I know that the open census module has since been deprecated but as we are currently dealing with this problem and the ETA for open census' replacement is yet to be determined, I think taking on this issue is still viable.

@tessig
Copy link
Member

tessig commented Jan 12, 2023

closed by #310

@tessig tessig closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants