Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base path to ServerErrorResponse #112

Merged
merged 4 commits into from Feb 3, 2020
Merged

add base path to ServerErrorResponse #112

merged 4 commits into from Feb 3, 2020

Commits on Jan 31, 2020

  1. add base path to ServerErrorResponse 

    The root path in my project is configurable via
flamingo.router.path: %%ENV:BASE_PATH%%/gateway/%%

My error pages are static HTML. So, if the above path changes all CSS and assets of my error pages won't be found anymore.
Having base available in the DataResponse would allow me to set the path "dynamically" in my static HMTL like so:

Considering all other options and given this is an edge case for a Flamingo environment, I find this to be the least invasive option to the problem.

Thanks for approving my request!
    @doertydoerk
    doertydoerk committed Jan 31, 2020
    Copy the full SHA
    aabb6f8 View commit details
    Browse the repository at this point in the history

  2. framework/web: add base path to ServerErrorResposne

    Dirk Gerretz committed Jan 31, 2020
    Copy the full SHA
    9d78726 View commit details
    Browse the repository at this point in the history

  3. framework/web: add tests for ServerErrorResponse (for Brian ;-) )

    Dirk Gerretz committed Jan 31, 2020
    Copy the full SHA
    aae92f1 View commit details
    Browse the repository at this point in the history

  4. remove docs.go

    Dirk Gerretz committed Jan 31, 2020
    Copy the full SHA
    596bf1e View commit details
    Browse the repository at this point in the history