Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type ResourceStore #1366

Merged
merged 1 commit into from Dec 11, 2019
Merged

Type ResourceStore #1366

merged 1 commit into from Dec 11, 2019

Conversation

rosskevin
Copy link
Collaborator

@rosskevin rosskevin commented Nov 28, 2019 •
edited

This is my interpretation of the runtime code and requires review for accuracy

Closes #1364

/cc @fromi

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.312% when pulling 26cb6ab on rosskevin:ts-resourcestore into f27eba8 on i18next:master.

@jamuhl
Copy link
Member

jamuhl commented Nov 29, 2019 •
edited

#1364 (comment) not against this...but it's in the gray shade of private/public API

@rosskevin
Copy link
Collaborator Author

I'm good with this as long as it is factually representative, even though it may not be preferred access.

@rosskevin rosskevin merged commit 72703cd into i18next:master Dec 11, 2019
@rosskevin rosskevin deleted the ts-resourcestore branch December 11, 2019 22:49
@rosskevin
Copy link
Collaborator Author

This can be a patch release

@jamuhl
Copy link
Member

jamuhl commented Dec 12, 2019

was published in i18next@19.0.2

@mjbcopland mjbcopland mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamuhl jamuhl Awaiting requested review from jamuhl

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript: type of "i18next.services.resourceStore" is wrong
3 participants
@rosskevin @coveralls @jamuhl