Reimplement XSS-vulnerable sequential replacement code #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The interpolation resolution code inside translate.js is looping over
each key in the interpolation dictionary and applying the replacements
one at a time. This means that if untrusted user input contains the name
of another key in the dictionary, for example
'__lastName__', anunexpected interpolation can happen:
This combines with the unescaping suffix feature to cause XSS injection,
even with escapeInterpolation set to true. For example,
This PR fixes that by performing the replacements all at the same
time. This means that untrusted input cannot cause these unexpected
extra interpolations.