fixed an issue with several unescaped key in the interpolation string #746

Merged
merged 2 commits into from Jun 23, 2016

Projects

None yet

3 participants

@de-robat
de-robat commented Jun 22, 2016 edited

corresponding pull request for issue: #747 .
please review and let me know what you think. Thanks!

@coveralls
coveralls commented Jun 22, 2016 edited

Coverage Status

Coverage increased (+0.1%) to 64.563% when pulling 622b303 on de-robat:master into 4ff5c54 on i18next:master.

@jamuhl
Member
jamuhl commented Jun 22, 2016

there is currently one test failing (compatibility) - will look into this tomorrow

@de-robat
de-robat commented Jun 22, 2016 edited

yep i saw it and ressorted to the old way of going with "lastIndex=0" for the unescaped case as well. this leaves the backwards compatibility untouched. Hope the reassesment of travis will proof that :D unfortuneatley i just tested with the "npm run tdd" test in the beginning. sry for the inconveniences!

@jamuhl
Member
jamuhl commented Jun 22, 2016

np...got no time today...so expect it to land tomorrow

@coveralls
coveralls commented Jun 22, 2016 edited

Coverage Status

Coverage increased (+0.04%) to 64.477% when pulling 38821cd on de-robat:master into 4ff5c54 on i18next:master.

@de-robat

ok, tomorrow will be sufficient for me :) Once more: ty!

@jamuhl jamuhl merged commit ecde4a8 into i18next:master Jun 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamuhl
Member
jamuhl commented Jun 23, 2016

thanks you for the contribution: just published i18next@3.3.1 including this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment