Fix Interpolator formatter exception error propagation due to not reset RegExp indices #820

Merged
merged 1 commit into from Sep 20, 2016

Projects

None yet

3 participants

@GillesRasigade
Contributor
GillesRasigade commented Sep 20, 2016 edited

If we define a custom formatter function which raises an exception, this one can be handled but let a wrong Interpolator state leading to an error on the next translation loop.

@GillesRasigade GillesRasigade Fix Interpolator formatter exception error propagation due to not res…
…et RegExp indices
b4c9d51
@coveralls

Coverage Status

Coverage increased (+0.08%) to 64.852% when pulling b4c9d51 on GillesRasigade:fix-formatter-exception-interpolator-regexp-index-error into 66f7a05 on i18next:master.

@jamuhl jamuhl merged commit 431809f into i18next:master Sep 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 64.852%
Details
@jamuhl
Member
jamuhl commented Sep 20, 2016

thank you for taking the time to create this PR. just published i18next@3.4.3 including this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment