Fix Interpolator.escapeValue defaulting to undefined in some cases #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I found that if I pass any
interpolationoptions without includingescapeValue,this.escapeValuewill get set toundefinedinInterpolator. The documentation indicatesescapeValuedefaults totrue, so this could cause variables to not be escaped as expected in some cases.This config, for example, will result in
i18nextnot escaping variables as expected:It's worth noting that it could potentially be a XSS security issue for users of
i18nextif they believe variables are getting escaped when they actually aren't.