Create an new translator when clone i18next instance #834

Merged
merged 1 commit into from Nov 7, 2016

Projects

None yet

3 participants

@anson0370
Contributor

I'm not sure is this the best way to fix it. And I reran all the tests, all passed.

#833

@anson0370 anson0370 create new translator when clone i18next
7dd349b
@coveralls

Coverage Status

Coverage increased (+0.006%) to 64.858% when pulling 7dd349b on anson0370:new-translator-instance-when-clone into 62c6917 on i18next:master.

@jamuhl
Member
jamuhl commented Nov 4, 2016

looks right for me...will merge this asap...and publish a new version (not sure but might be a breaking version - but would prefer patch - as it fixes behaviour)

@jamuhl jamuhl merged commit 0ad42b6 into i18next:master Nov 7, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 64.858%
Details
@anson0370 anson0370 deleted the anson0370:new-translator-instance-when-clone branch Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment