Return namespace in cimode with appendNamespaceToCIMode option #863
Conversation
| @@ -56,17 +56,25 @@ class Translator extends EventEmitter { | |||
| if (typeof keys === 'number') keys = String(keys); | |||
| if (typeof keys === 'string') keys = [keys]; | |||
|
|
|||
| // return key on CIMode | |||
| let lng = options.lng || this.language; | |||
| if (lng && lng.toLowerCase() === 'cimode') return keys[keys.length - 1]; | |||
There was a problem hiding this comment.
My tests for when appendNamespaceToCIMode: false failed initially before changes. This appears to be returning everything including the namespace if it is passed directly in the key (it is called before this.extractFromKey. I am not exactly sure why because this is the behavior I get in my application.
Below I started using key from this.exctractFromKey. Let me know if that was a bad idea.
|
Thanks for the PR...your change is ok...just need to think if i need to make this a breaking version - as we get different results now. For sure like this more as no random ns:key or key only depending on the calling code. |
|
We use e.g. in I looked at versions as well as file history and I have no idea why. Anyway I am glad you approve of this approach. Since the behavior is different I would recommend a major version bump in case anyone depends on existing behavior. (unfortunately) |
|
I also created a PR for i18next.com here: |
|
just published i18next@6.0.0 |
No description provided.