Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store should be initialized after useSSR #1008

Merged
merged 1 commit into from Nov 27, 2019
Merged

Store should be initialized after useSSR #1008

merged 1 commit into from Nov 27, 2019

Conversation

@fromi
Copy link
Contributor

fromi commented Nov 27, 2019

If a the store is initialized with data from Server side rendering, it fire these warnings anyway:
i18next was not initialized... This means something IS WRONG in your application setup.
However, the application setup is fine, the warning is inconsistent.
I think this PR will do the trick: i18n should be considered as initialize once it receive initialI18nStore datas.

If a the store is initialized with data from Server side rendering, it fire these warnings anyway:
`i18next was not initialized... This means something IS WRONG in your application setup.`
However, the application setup is fine, the warning is inconsistent.
I think this PR will do the trick: i18n should be considered as initialize once it receive initialI18nStore datas.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 27, 2019

Coverage Status

Coverage increased (+0.01%) to 95.249% when pulling 6277ab8 on fromi:patch-1 into c909875 on i18next:master.

@jamuhl jamuhl merged commit 4694a98 into i18next:master Nov 27, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage increased (+0.01%) to 95.249%
Details
workflow Workflow: workflow
Details
@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Nov 27, 2019

seems correct -> published in react-i18next@11.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.