Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ComponentType for Trans' `parent` type. #1021

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@pcorpet
Copy link
Contributor

pcorpet commented Dec 13, 2019

I've also allowed null as this is the cleanest way I use to override the default parent:

  • undefined -> use default parent from settings
  • string | React.ComponentType<any> -> use in React.createElement
  • null -> do not add a parent
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2019

Coverage Status

Coverage remained the same at 95.261% when pulling f705959 on pcorpet:parent-type into 40b77e0 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin Dec 13, 2019
Copy link
Collaborator

rosskevin left a comment

Please update the usage tests in test/typescript and add these additional cases to prevent regressions.

@pcorpet pcorpet force-pushed the pcorpet:parent-type branch from 4792396 to 730f886 Dec 13, 2019
@pcorpet pcorpet force-pushed the pcorpet:parent-type branch from 730f886 to f705959 Dec 13, 2019
@pcorpet

This comment has been minimized.

Copy link
Contributor Author

pcorpet commented Dec 13, 2019

Please update the usage tests in test/typescript and add these additional cases to prevent regressions.

Done. Thanks for the quick review.

Copy link
Collaborator

rosskevin left a comment

Thanks for the updates

@rosskevin rosskevin merged commit 092bd44 into i18next:master Dec 13, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 95.261%
Details
workflow Workflow: workflow
Details
@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Dec 13, 2019

This can be a patch release

@jamuhl

This comment has been minimized.

Copy link
Member

jamuhl commented Dec 18, 2019

sorry for the delay...was published in react-i18next@11.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.